-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] RadioButton a11y #10832
Merged
Merged
[iOS] RadioButton a11y #10832
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
64bd3c7
First attempt of radiobutton a11y
rachelkang 2f8ad79
Make Switch trait work as expected
rachelkang 62f3ae4
Update control gallery sample
rachelkang a35983d
Make class internal for potential backport
rachelkang 4c035a0
Update based on feedback
rachelkang 82fa3a6
Add comment
rachelkang 07f7ec1
Update based on feedback
rachelkang 610eac9
Refactor based on feedback
rachelkang ba979df
Update
rachelkang 390154f
Update
rachelkang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
using System; | ||
using CoreGraphics; | ||
using Microsoft.Maui.Graphics; | ||
using ObjCRuntime; | ||
using UIKit; | ||
|
||
namespace Microsoft.Maui.Platform; | ||
|
||
internal class MauiRadioButton : ContentView | ||
{ | ||
IRadioButton _radioButton; | ||
UIAccessibilityTrait _accessibilityTraits; | ||
|
||
internal MauiRadioButton(IRadioButton virtualView) | ||
{ | ||
_radioButton = virtualView; | ||
CrossPlatformMeasure = virtualView.CrossPlatformMeasure; | ||
CrossPlatformArrange = virtualView.CrossPlatformArrange; | ||
IsAccessibilityElement = true; | ||
} | ||
|
||
static UIKit.UIAccessibilityTrait? s_switchAccessibilityTraits; | ||
UIKit.UIAccessibilityTrait SwitchAccessibilityTraits | ||
{ | ||
get | ||
{ | ||
if (s_switchAccessibilityTraits == null || | ||
s_switchAccessibilityTraits == UIKit.UIAccessibilityTrait.None) | ||
{ | ||
s_switchAccessibilityTraits = new UIKit.UISwitch().AccessibilityTraits; | ||
} | ||
|
||
return s_switchAccessibilityTraits ?? UIKit.UIAccessibilityTrait.None; | ||
} | ||
} | ||
|
||
public override UIAccessibilityTrait AccessibilityTraits | ||
{ | ||
get => _accessibilityTraits |= SwitchAccessibilityTraits; | ||
set => _accessibilityTraits = value | SwitchAccessibilityTraits; | ||
} | ||
|
||
public override string? AccessibilityValue | ||
{ | ||
get => _radioButton.IsChecked ? "1" : "0"; | ||
set { } | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we follow the same pattern here as
MauiCheckBox
? and just makeIsChecked
a property onMauiRadioButton
?