[dotnet] use **FromWorkload** for targeting/runtime pack versions #12449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On the Android side we could do this when we got on .NET I'll come back to this after this PR lands: #12357 |
🔥 Tests failed catastrophically on Build (no summary found). 🔥Result file $(TEST_SUMMARY_PATH) not found. |
spouliot
approved these changes
Aug 16, 2021
c015e7a to
6ea5947
Compare
Context: dotnet/sdk#19596 Context: dotnet/android#6184 If we use the version number string of `**FromWorkload**`, then our runtime packages don't need to be resolved from a NuGet feed. They can be resolved from the `dotnet/packs` directory. This completely eliminates the need for a `NuGet.config` file when building a .NET 6 app with a local build of the xamarin-macios. You will no longer need a feed such as: <add key="local-dotnet-feed" value="~/src/xamarin-macios/_build/nuget-feed" /> To further clean things up, I removed the need for: * Any NuGet feed named `local-dotnet-feed` * `$(DOTNET_FEED_DIR)` * Generation of `dotnet/Workloads/NuGet.config`
6ea5947 to
549dc28
Compare
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results5 tests failed, 138 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
|
Test failures are unrelated:
|
rolfbjarne
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/sdk#19596
Context: dotnet/android#6184
If we use the version number string of
**FromWorkload**, then ourruntime packages don't need to be resolved from a NuGet feed. They can
be resolved from the
dotnet/packsdirectory.This completely eliminates the need for a
NuGet.configfile whenbuilding a .NET 6 app with a local build of xamarin-macios.
You will no longer need a feed such as:
To further clean things up, I removed the need for:
local-dotnet-feed$(DOTNET_FEED_DIR)dotnet/Workloads/NuGet.config