[Xtro] If the sanitizer removed all selectors, remove the file. #12256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new check was added to ensure that empty .todo files are not added, yet when the sanitizer removes all lines we get an error per empty file. Since we are auto-sanitizing, we want to remove those empty files.
stephen-hawley
approved these changes
Jul 27, 2021
spouliot
suggested changes
Jul 27, 2021
| @@ -177,6 +177,10 @@ static void NoFixedTodo () | |||
| foreach (var failure in failures) | |||
| sanitized.Remove (failure); | |||
| File.WriteAllLines (file, sanitized); | |||
| // since we are in AUTO_SANITIZE, if the file is empty, remove it. | |||
| if (!(File.ReadLines(file).Count() > 0)) { | |||
There was a problem hiding this comment.
wrong style, space before (
There was a problem hiding this comment.
why not simply look if sanitized is empty ?
instead of reading back the file (that was just written)
spouliot
reviewed
Jul 27, 2021
| @@ -178,7 +178,7 @@ static void NoFixedTodo () | |||
| sanitized.Remove (failure); | |||
| File.WriteAllLines (file, sanitized); | |||
| // since we are in AUTO_SANITIZE, if the file is empty, remove it. | |||
| if (!(File.ReadLines(file).Count() > 0)) { | |||
| if (!(sanitized.Count () > 0)) { | |||
There was a problem hiding this comment.
Simpler
if (sanitized.Count == 0) {No LINQ, no negation
mandel-macaque
commented
Jul 27, 2021
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 86 tests passed.Failed tests
Pipeline on Agent XAMBOT-1101.BigSur' |
rolfbjarne
approved these changes
Jul 28, 2021
spouliot
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new check was added to ensure that empty .todo files are not added,
yet when the sanitizer removes all lines we get an error per empty file.
Since we are auto-sanitizing, we want to remove those empty files.