[dotnet/msbuild] Fix packaging and archiving support in .NET. Partial fix for #10413. #12244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t files to shared target files. Because we need it for Mac Catalyst as well.
…p signature, not the executable. Just like they are for macOS apps.
…he things we need to do at build time * CreateIpa: only executed if 'BuildIpa' is set. * _CreateInstaller: only executed if 'CreatePackage' is set. * Archive: only executed if 'ArchiveOnBuild' is set. We don't do this for inner builds of multi-rid builds, only single-rid builds or outer builds of multi-rid builds.
We use two different properties for the same thing: MtouchEnableSGenConc and EnableSGenConc. Going forward, we're sticking with just EnableSGenConc, but we'll keep accepting MtouchEnableSGenConc if it's set.
So that it's set for both macOS and Mac Catalyst.
This makes it easier to use the same csproj for multiple platforms for customers.
…equired to take Mac Catalyst into account
…talyst app.
We fail later with an uninformative error ('The "Archive" task was not given a
value for the required parameter "SigningKey"') otherwise, and this way the
user doesn't have to manually enable signing to avoid the this error.
…'re before they participate in conditions.
5 tasks
There was a main version of this target for Xamarin.iOS, and then numerous dummy targets for two scenarios: * Building app extensions. * Building macOS apps. The first one is handled by the '_CanArchive' property (will be false when building app extensions), and for the second case I've added it to the condition on the CreateIpa target. This way we don't have to have logic elsewhere about when it's valid to call CreateIpa.
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results88 tests failed, 30 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results5 tests failed, 113 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results3 tests failed, 115 tests passed.Failed tests
Pipeline on Agent XAMBOT-1099.BigSur' |
|
Test failures are unrelated (all due to https://github.com/xamarin/maccore/issues/2481). |
emaf
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can also be used for Mac Catalyst.
Partial fix for #10413.
This PR is probably easiest to review commit-by-commit.