[maccatalyst] Increase iOS compatibility by removing XAMCORE_3_0
#11238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`XAMCORE_3_0` was added in tvOS and watchOS where binary compatibility was not a consideration. The work to update source code for `XAMCORE_3_0` was also minimal. The former is not the always the case for MacCatalyst, while the latter is still true. Fix dotnet#11237 and dotnet#11236
dalexsoto
approved these changes
Apr 19, 2021
mandel-macaque
approved these changes
Apr 19, 2021
❌ Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffTest results2 tests failed, 97 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur |
🔥 Tests failed catastrophically on Build (no summary found). 🔥Result file $(TEST_SUMMARY_PATH) not found. |
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rolfbjarne
approved these changes
Apr 20, 2021
|
Failure is unrelated, known issue -> https://github.com/xamarin/maccore/issues/2411 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XAMCORE_3_0was added in tvOS and watchOS where binary compatibilitywas not a consideration. The work to update source code for
XAMCORE_3_0was also minimal.
The former is not the always the case for MacCatalyst, while the latter
is still true.
Fix #11237 and #11236