Skip to content

Commit

Permalink
[coremotion] Add nullability to (generated and manual) bindings (#15072)
Browse files Browse the repository at this point in the history
Co-authored-by: tj_devel709 <antlambe@microsoft.com>
  • Loading branch information
tj-devel709 and tj_devel709 authored May 20, 2022
1 parent 03c3b30 commit b773b97
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/CoreMotion/CMCompat.cs
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
// Copyright 2016 Xamarin Inc. All rights reserved.

#nullable enable

#if !XAMCORE_3_0 && !MONOMAC

using System;
Expand All @@ -10,7 +12,7 @@ namespace CoreMotion {
public partial class CMSensorRecorder {

[Obsolete ("Apple removed this API in iOS 9.3.")]
public virtual CMSensorDataList GetAccelerometerDataSince (ulong identifier)
public virtual CMSensorDataList? GetAccelerometerDataSince (ulong identifier)
{
return null;
}
Expand Down
2 changes: 2 additions & 0 deletions src/CoreMotion/CMDeviceMotion.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
//
// Copyright (C) 2011-2014 Xamarin Inc

#nullable enable

using System;
using System.Runtime.InteropServices;

Expand Down
3 changes: 3 additions & 0 deletions src/CoreMotion/CMMagnetometer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
// Authors:
// Miguel de Icaza
//

#nullable enable

using System.Runtime.InteropServices;

namespace CoreMotion {
Expand Down
2 changes: 2 additions & 0 deletions src/CoreMotion/CMSensorDataList.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
// Rolf Bjarne Kvinge
//

#nullable enable

#if !MONOMAC

using System.Collections.Generic;
Expand Down
2 changes: 2 additions & 0 deletions src/CoreMotion/Defs.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// CoreMotion's struct and enum definitions used by the API file
//

#nullable enable

using System;
using System.Runtime.InteropServices;
using System.Runtime.Versioning;
Expand Down
3 changes: 3 additions & 0 deletions src/CoreMotion/Extras.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
//
// CoreMotion's extra methods
//

#nullable enable

using Foundation;
using System;

Expand Down

5 comments on commit b773b97

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💻 [CI Build] Tests on macOS Mac Catalina (10.15) passed 💻

All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: b773b97b9b846ab1f3a6d46a10577b6f71538a7e

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 [CI Build] API Diff 📋

API diff (for current PR)

ℹ️ API Diff (from PR only) (please review changes)

API diff: vsdrops gist

Xamarin
.NET
Xamarin vs .NET
iOS vs Mac Catalyst (.NET)

API diff (vs stable)

✅ API Diff from stable

API diff: vsdrops gist

Xamarin
.NET
Xamarin vs .NET
iOS vs Mac Catalyst (.NET)

Generator diff

Generator Diff (no change)

Pipeline on Agent XAMMINI-060.Monterey'
Hash: b773b97b9b846ab1f3a6d46a10577b6f71538a7e

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • xammac_tests
  • monotouch-test

Pipeline on Agent
Hash: b773b97b9b846ab1f3a6d46a10577b6f71538a7e

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📚 [CI Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMMINI-049.Monterey
Hash: b773b97b9b846ab1f3a6d46a10577b6f71538a7e

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌

Tests failed on VSTS: simulator tests iOS.

Test results

1028 tests' device not found, 228 tests passed.

Pipeline on Agent XAMBOT-1101.Monterey'
[coremotion] Add nullability to (generated and manual) bindings (#15072)

Please sign in to comment.