Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Net8 tests #7319

Merged
merged 48 commits into from
Dec 16, 2024
Merged
Show file tree
Hide file tree
Changes from 38 commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
5e6ed1a
net 8 working on windows
michaelgsharp Nov 20, 2024
d495c4c
net core fixes
michaelgsharp Nov 20, 2024
2535418
fixing job template
michaelgsharp Nov 20, 2024
cb78448
include net8 for helix
michaelgsharp Nov 20, 2024
f84fb69
more net8 changes
michaelgsharp Nov 20, 2024
489fab9
Adding needed tfm check back.
michaelgsharp Nov 20, 2024
39f7807
Fixing global json
michaelgsharp Nov 20, 2024
66b130c
missed net upgrade.
michaelgsharp Nov 20, 2024
1301e6d
re-adding containers
michaelgsharp Nov 20, 2024
e84ec25
fix x86 order
michaelgsharp Nov 21, 2024
d7eb263
arm 64 changes
michaelgsharp Nov 21, 2024
fae4a9a
arm 64 missed files
michaelgsharp Nov 21, 2024
4da3877
continue on error
michaelgsharp Nov 22, 2024
faa175d
win arm
michaelgsharp Nov 22, 2024
e797c19
linux arm64
michaelgsharp Nov 22, 2024
2f5047e
missing linux arm64 files
michaelgsharp Nov 22, 2024
e23e47b
Removing extra parameter
michaelgsharp Nov 22, 2024
ffa86df
test helix upload
michaelgsharp Nov 22, 2024
16fad35
semi colon escape
michaelgsharp Nov 23, 2024
47439ba
escape ampersand
michaelgsharp Nov 23, 2024
a19afa9
fixing bash copy
michaelgsharp Nov 23, 2024
a638909
upload test
michaelgsharp Nov 26, 2024
af004c4
cp test
michaelgsharp Nov 26, 2024
ed44308
arm files
michaelgsharp Dec 4, 2024
44f3cb4
relax arm constraints
michaelgsharp Dec 4, 2024
5e23157
missed arm file
michaelgsharp Dec 4, 2024
fe40b56
Fixes.
michaelgsharp Dec 7, 2024
22dd928
data analysis sequential tests
michaelgsharp Dec 8, 2024
b5b7c35
build analysis changes
michaelgsharp Dec 9, 2024
3993097
fix helix.proj
michaelgsharp Dec 9, 2024
36ccf7c
templating
michaelgsharp Dec 9, 2024
fc88832
reorder proj
michaelgsharp Dec 9, 2024
5ca091a
helix changes
michaelgsharp Dec 10, 2024
577e4ae
Helix Restore separate
michaelgsharp Dec 11, 2024
12eeb26
fixed yml
michaelgsharp Dec 11, 2024
9090999
Update build/ci/send-to-helix.yml
ericstj Dec 11, 2024
a6f1973
Fix execution of CreateHelixWorkItems target
ericstj Dec 11, 2024
0f68e7f
Schedule CreateHelixWorkItems BeforeTest
ericstj Dec 11, 2024
86504cc
helix proj change
michaelgsharp Dec 11, 2024
85e0d96
helix proj change
michaelgsharp Dec 11, 2024
86b682c
Helix Updates
michaelgsharp Dec 12, 2024
00f6347
helix proj change
michaelgsharp Dec 12, 2024
a0ff186
.sh test file update
michaelgsharp Dec 12, 2024
923b6fe
more helix changes
michaelgsharp Dec 12, 2024
79ec095
Removing commented code
michaelgsharp Dec 12, 2024
25b5301
added ability to run GC after tests
michaelgsharp Dec 12, 2024
4e137f3
adding missed files
michaelgsharp Dec 12, 2024
278b277
netfx fix
michaelgsharp Dec 13, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions .vsts-dotnet-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,20 +52,20 @@ jobs:
- template: /build/ci/job-template.yml
parameters:
architecture: arm
name: Ubuntu_x64_cross_arm_Net60
name: Ubuntu_x64_cross_arm
buildScript: ./build.sh
container: UbuntuCrossArmContainer
customMatrixes:
Debug_Build:
_configuration: Debug
_config_short: DI
_includeBenchmarkData: false
_targetFramework: net6.0
_targetFramework: net8.0
Release_Build:
_configuration: Release
_config_short: RI
_includeBenchmarkData: true
_targetFramework: net6.0
_targetFramework: net8.0
innerLoop: true
pool:
name: NetCore-Public
Expand All @@ -75,20 +75,20 @@ jobs:
- template: /build/ci/job-template.yml
parameters:
architecture: arm64
name: Ubuntu_x64_cross_arm64_Net60
name: Ubuntu_x64_cross_arm64
buildScript: ./build.sh
container: UbuntuCrossArm64Container
customMatrixes:
Debug_Build:
_configuration: Debug
_config_short: DI
_includeBenchmarkData: false
_targetFramework: net6.0
_targetFramework: net8.0
Release_Build:
_configuration: Release
_config_short: RI
_includeBenchmarkData: true
_targetFramework: net6.0
_targetFramework: net8.0
innerLoop: true
pool:
name: NetCore-Public
Expand All @@ -97,7 +97,7 @@ jobs:

- template: /build/ci/job-template.yml
parameters:
name: Centos_x64_Net60
name: Centos_x64
buildScript: ./build.sh
container: CentosContainer
innerLoop: true
Expand All @@ -108,7 +108,7 @@ jobs:

- template: /build/ci/job-template.yml
parameters:
name: Ubuntu_x64_Net60
name: Ubuntu_x64
buildScript: ./build.sh
container: UbuntuContainer
innerLoop: true
Expand All @@ -119,7 +119,7 @@ jobs:

- template: /build/ci/job-template.yml
parameters:
name: MacOS_x64_Net60
name: MacOS_x64
buildScript: ./build.sh
innerLoop: true
pool:
Expand All @@ -129,19 +129,19 @@ jobs:
- template: /build/ci/job-template.yml
parameters:
architecture: arm64
name: MacOS_cross_arm64_Net6
name: MacOS_cross_arm64
buildScript: ./build.sh
customMatrixes:
Debug_Build:
_configuration: Debug
_config_short: DI
_includeBenchmarkData: false
_targetFramework: net6.0
_targetFramework: net8.0
Release_Build:
_configuration: Release
_config_short: RI
_includeBenchmarkData: true
_targetFramework: net6.0
_targetFramework: net8.0
innerLoop: true
pool:
vmImage: macOS-13
Expand All @@ -150,19 +150,19 @@ jobs:
- template: /build/ci/job-template.yml
parameters:
architecture: arm64
name: Windows_cross_arm64_Net6
name: Windows_cross_arm64
buildScript: build.cmd
customMatrixes:
Debug_Build:
_configuration: Debug
_config_short: DI
_includeBenchmarkData: false
_targetFramework: net6.0
_targetFramework: net8.0
Release_Build:
_configuration: Release
_config_short: RI
_includeBenchmarkData: false
_targetFramework: net6.0
_targetFramework: net8.0
innerLoop: true
vsTestConfiguration: "/Framework:.NETCoreApp,Version=v6.0"
pool:
Expand All @@ -172,7 +172,7 @@ jobs:

- template: /build/ci/job-template.yml
parameters:
name: Windows_x64_Net6
name: Windows_x64
buildScript: build.cmd
innerLoop: true
vsTestConfiguration: "/Framework:.NETCoreApp,Version=v3.1"
Expand Down Expand Up @@ -205,7 +205,7 @@ jobs:

- template: /build/ci/job-template.yml
parameters:
name: Windows_x86_Net6
name: Windows_x86
architecture: x86
buildScript: build.cmd
innerLoop: true
Expand Down
2 changes: 1 addition & 1 deletion build/Codecoverage.proj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<!-- We need to specify a framework in order for the Restore target to work -->
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
Expand Down
16 changes: 8 additions & 8 deletions build/ci/job-template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,12 @@ jobs:
_configuration: Debug
_config_short: D
_includeBenchmarkData: false
_targetFramework: net6.0
_targetFramework: net8.0
Release_Build:
_configuration: Release
_config_short: R
_includeBenchmarkData: true
_targetFramework: net6.0
_targetFramework: net8.0
${{ if ne(parameters.customMatrixes, '') }}:
${{ insert }}: ${{ parameters.customMatrixes }}

Expand All @@ -76,7 +76,7 @@ jobs:
- ${{ if and( eq(parameters.nightlyBuild, 'true'), eq(parameters.pool.vmImage, 'ubuntu-18.04')) }}:
- bash: echo "##vso[task.setvariable variable=LD_LIBRARY_PATH]$(nightlyBuildRunPath):$LD_LIBRARY_PATH"
displayName: Set LD_LIBRARY_PATH for Ubuntu and CentOS to locate Native shared library in current running path
- script: ${{ parameters.buildScript }} -configuration $(_configuration) /p:TargetArchitecture=${{ parameters.architecture }} /p:TestArchitectures=${{ parameters.architecture }} /p:Coverage=${{ parameters.codeCoverage }} $(testTargetFramework) /p:CreateHardLinksForCopyFilesToOutputDirectoryIfPossible=True $(hardLink)
- script: ${{ parameters.buildScript }} -configuration $(_configuration) /p:TargetArchitecture=${{ parameters.architecture }} /p:Coverage=${{ parameters.codeCoverage }} $(testTargetFramework) /p:CreateHardLinksForCopyFilesToOutputDirectoryIfPossible=True $(hardLink)
displayName: Build
- ${{ if eq(parameters.pool.vmImage, 'macOS-10.15') }}:
- task: Bash@3
Expand Down Expand Up @@ -116,15 +116,15 @@ jobs:
displayName: Clean up useless project
- script: $(dotnetPath) msbuild -restore $(nightlyBuildProjPath) /p:ReferenceTypeForTestFramework="Nuget" /p:Configuration=$(_configuration) /p:TargetArchitecture=${{ parameters.architecture }} $(testTargetFramework)
displayName: Build Nightly-Build Project with latest package versions
- script: $(dotnetPath) msbuild $(runNightlyBuildProj) /t:RunNightlyBuildTests /p:Configuration=$(_configuration) /p:TargetArchitecture=${{ parameters.architecture }} /p:TestArchitectures=${{ parameters.architecture }} $(testTargetFramework)
- script: $(dotnetPath) msbuild $(runNightlyBuildProj) /t:RunNightlyBuildTests /p:Configuration=$(_configuration) /p:TargetArchitecture=${{ parameters.architecture }} $(testTargetFramework)
displayName: Run Nightly Build Tests
- ${{ if eq(parameters.nightlyBuild, 'false') }}:
- ${{ if eq(parameters.innerLoop, 'false') }}:
- ${{ if and(eq(parameters.runSpecific, 'false'), eq(parameters.useVSTestTask, 'false')) }}:
- script: set PATH=%PATH%;%USERPROFILE%\.nuget\packages\libtorch-cpu-win-x64\2.2.1.1\runtimes\win-x64\native;%USERPROFILE%\.nuget\packages\torchsharp\0.102.7\runtimes\win-x64\native & ${{ parameters.buildScript }} /p:Build=false -configuration $(_configuration) /p:TargetArchitecture=${{ parameters.architecture }} /p:TestArchitectures=${{ parameters.architecture }} -test -integrationTest /p:Coverage=${{ parameters.codeCoverage }} $(testTargetFramework)
- script: set PATH=%PATH%;%USERPROFILE%\.nuget\packages\libtorch-cpu-win-x64\2.2.1.1\runtimes\win-x64\native;%USERPROFILE%\.nuget\packages\torchsharp\0.102.7\runtimes\win-x64\native & ${{ parameters.buildScript }} /p:Build=false -configuration $(_configuration) /p:TargetArchitecture=${{ parameters.architecture }} -test -integrationTest /p:Coverage=${{ parameters.codeCoverage }} $(testTargetFramework)
displayName: Run All Tests.
- ${{ if and(eq(parameters.runSpecific, 'true'), eq(parameters.useVSTestTask, 'false')) }}:
- script: ${{ parameters.buildScript }} /p:Build=false -configuration $(_configuration) /p:TargetArchitecture=${{ parameters.architecture }} /p:TestArchitectures=${{ parameters.architecture }} -test -integrationTest /p:TestRunnerAdditionalArguments='-trait$(spaceValue)Category=RunSpecificTest' /p:Coverage=${{ parameters.codeCoverage }} $(testTargetFramework)
- script: ${{ parameters.buildScript }} /p:Build=false -configuration $(_configuration) /p:TargetArchitecture=${{ parameters.architecture }} -test -integrationTest /p:TestRunnerAdditionalArguments='-trait$(spaceValue)Category=RunSpecificTest' /p:Coverage=${{ parameters.codeCoverage }} $(testTargetFramework)
displayName: Run Specific Tests.
- ${{ if and(eq(parameters.buildScript, 'build.cmd'), eq(parameters.useVSTestTask, 'true')) }}:
- task: VSTest@2
Expand All @@ -149,7 +149,7 @@ jobs:
publishRunAttachments: true
- ${{ if eq(parameters.innerLoop, 'true') }}:
- ${{ if eq(parameters.codeCoverage, True) }}:
- script: ${{ parameters.buildScript }} /p:Build=false -configuration $(_configuration) /p:TargetArchitecture=${{ parameters.architecture }} /p:TestArchitectures=${{ parameters.architecture }} -test -integrationTest /p:TestRunnerAdditionalArguments='-notrait$(spaceValue)Category=SkipInCI' /p:Coverage=${{ parameters.codeCoverage }} $(testTargetFramework)
- script: ${{ parameters.buildScript }} /p:Build=false -configuration $(_configuration) /p:TargetArchitecture=${{ parameters.architecture }} -test -integrationTest /p:TestRunnerAdditionalArguments='-notrait$(spaceValue)Category=SkipInCI' /p:Coverage=${{ parameters.codeCoverage }} $(testTargetFramework)
displayName: Run CI Tests.
- ${{ if eq(parameters.codeCoverage, False) }}:
- template: /build/ci/send-to-helix.yml
Expand Down Expand Up @@ -236,5 +236,5 @@ jobs:
script: Get-ChildItem -Path '.\artifacts\bin' -Recurse | Where-Object {$_.FullName -like "*runtimes*"} | Remove-Item -Recurse -Confirm:$false -Force
displayName: Clean up runtime folder for package (Unix)
- ${{ if eq(parameters.nightlyBuild, 'false') }}:
- script: ${{ parameters.buildScript }} /p:Build=false -pack -ci -configuration $(_configuration) /p:TargetArchitecture=${{ parameters.architecture }} /p:TestArchitectures=${{ parameters.architecture }} $(testTargetFramework)
- script: ${{ parameters.buildScript }} /p:Build=false -pack -ci -configuration $(_configuration) /p:TargetArchitecture=${{ parameters.architecture }} $(testTargetFramework)
displayName: Build Packages
25 changes: 25 additions & 0 deletions build/ci/send-to-helix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,31 @@ parameters:
condition: succeeded() # optional -- condition for step to execute; defaults to succeeded()

steps:
- script: ${{ parameters.MsBuildScript}}
$(Build.SourcesDirectory)/eng/helix.proj
/t:Restore
/bl:$(Build.SourcesDirectory)/artifacts/log/${{ parameters.Configuration }}/SendToHelix.binlog
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This uses the same log as below, also most of these parameters are not needed for restore. I imagine this step is just temporary until we refactor in a follow up PR though.

/p:Configuration=${{ parameters.Configuration }}
/p:TargetArchitecture=${{ parameters.Architecture }}
/p:BuildConfig=${{ parameters.Configuration }}
/p:BuildArchitecture=${{ parameters.Architecture }}
/p:HelixSource=${{ parameters.HelixSource }}
/p:HelixType=${{ parameters.HelixType }}
/p:HelixBuild=${{ parameters.HelixBuild }}
/p:HelixConfiguration="${{ parameters.HelixConfiguration }}"
/p:HelixAccessToken="${{ parameters.HelixAccessToken }}"
/p:EnableXUnitReporter=${{ parameters.EnableXUnitReporter }}
/p:WaitForWorkItemCompletion=${{ parameters.WaitForWorkItemCompletion }}
/p:HelixBaseUri=${{ parameters.HelixBaseUri }}
${{ parameters.WarnAsError }}
${{ parameters.TestTargetFramework }}
displayName: "Helix Restore"
env:
SYSTEM_ACCESSTOKEN: $(System.AccessToken)
Creator: ${{ parameters.Creator }}
HelixTargetQueues: ${{ parameters.HelixTargetQueues }}
continueOnError: ${{ parameters.continueOnError }}

- script: ${{ parameters.MsBuildScript}}
$(Build.SourcesDirectory)/eng/helix.proj
/t:Test
Expand Down
2 changes: 1 addition & 1 deletion build/codecoverage-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
_configuration: Debug
_config_short: D
_includeBenchmarkData: false
_targetFramework: net6.0
_targetFramework: net8.0
codeCoverage: true
pool:
name: NetCore-Public
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<CopyLocalLockFileAssemblies>false</CopyLocalLockFileAssemblies>
<NoWarn>$(NoWarn)</NoWarn>

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<OutputType>Exe</OutputType>
<SignAssembly>false</SignAssembly>
<!--This ensures that we can never make the mistake of adding this as a friend assembly. Please don't remove.-->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<!--This ensures that we can never make the mistake of adding this as a friend assembly. Please don't remove.-->
<PublicSign>false</PublicSign>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<OutputType>Exe</OutputType>
<SignAssembly>false</SignAssembly>
<!--This ensures that we can never make the mistake of adding this as a friend assembly. Please don't remove.-->
Expand Down
1 change: 1 addition & 0 deletions eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@
<DotNetRuntime80Version>8.0.1</DotNetRuntime80Version>
<FluentAssertionVersion>6.12.0</FluentAssertionVersion>
<MicrosoftCodeAnalysisTestingVersion>1.1.2-beta1.23431.1</MicrosoftCodeAnalysisTestingVersion>
<MicrosoftDotNetBuildTasksTemplatingVersion>9.0.0-beta.24212.4</MicrosoftDotNetBuildTasksTemplatingVersion>
<MicrosoftDotNetPlatformAbstractionsVersion>5.0.0-preview.5.20278.1</MicrosoftDotNetPlatformAbstractionsVersion>
<MicrosoftDotNetRemoteExecutorVersion>8.0.0-beta.24525.2</MicrosoftDotNetRemoteExecutorVersion>
<MicrosoftDotNetXUnitExtensionsVersion>10.0.0-beta.24504.4</MicrosoftDotNetXUnitExtensionsVersion>
Expand Down
27 changes: 22 additions & 5 deletions eng/helix.proj
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.DotNet.Helix.Sdk" InitialTargets="CreateHelixWorkItems">
<Project Sdk="Microsoft.DotNet.Helix.Sdk">
<Choose>
<When Condition="$(HelixTargetQueues.ToLowerInvariant().Contains('windows'))">
<PropertyGroup>
Expand Down Expand Up @@ -39,10 +39,11 @@
</PropertyGroup>

<ItemGroup>
<AdditionalDotNetPackage Include="$(DotNetRuntime60Version)">
<AdditionalDotNetPackage Include="$(DotNetRuntime80Version)">
<PackageType>runtime</PackageType>
<DotNetCliRuntime Condition="'$(BuildArchitecture)' == 'x86'">win-x86</DotNetCliRuntime>
<DotNetCliRuntime Condition="'$(BuildArchitecture)' == 'arm' And $(HelixTargetQueues.ToLowerInvariant().Contains('ubuntu'))">linux-arm</DotNetCliRuntime>
<DotNetCliRuntime Condition="'$(BuildArchitecture)' == 'arm64' And $(HelixTargetQueues.ToLowerInvariant().Contains('osx'))">osx-arm64</DotNetCliRuntime>
</AdditionalDotNetPackage>
</ItemGroup>

Expand Down Expand Up @@ -89,7 +90,11 @@
</HelixCorrelationPayload>
</ItemGroup>

<Target Name="CreateHelixWorkItems">
<ItemGroup>
<PackageReference Include="Microsoft.DotNet.Build.Tasks.Templating" Version="$(MicrosoftDotNetBuildTasksTemplatingVersion)" PrivateAssets="All" />
</ItemGroup>

<Target Name="CreateHelixWorkItems" BeforeTargets="BeforeTest">
<MSBuild Projects="@(MyProjects)"
Targets="GetTargetFrameworks"
BuildInParallel="$(BuildInParallel)"
Expand All @@ -111,6 +116,13 @@
<HelixCorrelationPayloadPath Condition="$(IsPosixShell)">$HELIX_CORRELATION_PAYLOAD</HelixCorrelationPayloadPath>
<HelixCorrelationPayloadPath Condition="!$(IsPosixShell)">%HELIX_CORRELATION_PAYLOAD%</HelixCorrelationPayloadPath>

<RunTestScript Condition="'$(OS)' != 'Windows_NT'">runTests.sh</RunTestScript>
<RunTestScript Condition="'$(OS)' == 'Windows_NT'">./runTests.cmd</RunTestScript>

<RunCommand>dotnet exec --roll-forward Major --runtimeconfig %(ProjectsWithTargetFramework.Filename).runtimeconfig.json --depsfile %(ProjectsWithTargetFramework.Filename).deps.json $(HelixCorrelationPayloadPath)/xunit-runner/tools/netcoreapp2.0/xunit.console.dll %(ProjectsWithTargetFramework.Filename).dll -notrait Category=SkipInCI -xml testResults.xml</RunCommand>
<RunCommand Condition="$(TestTargetFramework.EndsWith('net462')) And %(ProjectsWithTargetFramework.TargetFrameworks) != 'net8.0'">$(HelixCorrelationPayloadPath)/xunit-runner/tools/net462/xunit.console.exe %(ProjectsWithTargetFramework.Filename).dll -notrait Category=SkipInCI -xml testResults.xml</RunCommand>


<MacFilesToCopy>/usr/local/opt/libomp/lib/libiomp5.dylib;/usr/local/opt/libomp/lib/libomp.dylib;</MacFilesToCopy>
<MacFilesToCopy Condition="$(HelixTargetQueues.ToLowerInvariant().Contains('arm64'))">/usr/local/opt/libomp/lib/libomp.dylib;</MacFilesToCopy>
</PropertyGroup>
Expand Down Expand Up @@ -149,16 +161,21 @@
<Delete Condition="$(HelixTargetQueues.ToLowerInvariant().Contains('ubuntu'))"
Files="@(WindowsFiles);@(OsxFiles)" />

<GenerateFileFromTemplate TemplateFile="$(MSBuildThisFileDirectory)testing\$(RunTestScript)"
OutputPath="$(TargetDir)$(RunTestScript)"
Properties="runCommand=$(RunCommand)" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This TargetDir is not correct. In my PR this worked because I would generate in the context of each test project, so TargetDir would point to the output of the test. Here you are running in the context of helix.proj so targetdir is the output directory of that one project. I think you need to instead generate into the test's directory, or somehow copy there.


<ItemGroup>
<HelixWorkItem Include="%(ProjectsWithTargetFramework.Filename)">
<PayloadDirectory>$(BUILD_SOURCESDIRECTORY)\artifacts\bin\%(ProjectsWithTargetFramework.Filename)\$(BuildConfig)\%(ProjectsWithTargetFramework.TargetFrameworks)\</PayloadDirectory>
<PayloadDirectory Condition="%(ProjectsWithTargetFramework.TargetFrameworks) == 'net462'">$(BUILD_SOURCESDIRECTORY)\artifacts\bin\%(ProjectsWithTargetFramework.Filename)\$(BuildConfig)\%(ProjectsWithTargetFramework.TargetFrameworks)\win-x64</PayloadDirectory>
<Command>dotnet exec --roll-forward Major --runtimeconfig %(ProjectsWithTargetFramework.Filename).runtimeconfig.json --depsfile %(ProjectsWithTargetFramework.Filename).deps.json $(HelixCorrelationPayloadPath)/xunit-runner/tools/netcoreapp2.0/xunit.console.dll %(ProjectsWithTargetFramework.Filename).dll -notrait Category=SkipInCI -xml testResults.xml</Command>
<Command Condition="$(TestTargetFramework.EndsWith('net462')) And %(ProjectsWithTargetFramework.TargetFrameworks) != 'net6.0'">$(HelixCorrelationPayloadPath)/xunit-runner/tools/net462/xunit.console.exe %(ProjectsWithTargetFramework.Filename).dll -notrait Category=SkipInCI -xml testResults.xml</Command>
<Command Condition="'$(OS)' != 'Windows_NT'">./$(RunTestScript)</Command>
<Command Condition="'$(OS)' == 'Windows_NT'">call $(RunTestScript)</Command>
<Timeout>01:00:00</Timeout>
<Timeout Condition="$(HelixTargetQueues.ToLowerInvariant().Contains('osx'))">00:30:00</Timeout>
<Timeout Condition="'$(WorkItemTimeout)' != ''">$(WorkItemTimeout)</Timeout>
</HelixWorkItem >
</ItemGroup>

</Target>
</Project>
Loading
Loading