Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Net8 tests #7319
Net8 tests #7319
Changes from 38 commits
5e6ed1a
d495c4c
2535418
cb78448
f84fb69
489fab9
39f7807
66b130c
1301e6d
e84ec25
d7eb263
fae4a9a
4da3877
faa175d
e797c19
2f5047e
e23e47b
ffa86df
16fad35
47439ba
a19afa9
a638909
af004c4
ed44308
44f3cb4
5e23157
fe40b56
22dd928
b5b7c35
3993097
36ccf7c
fc88832
5ca091a
577e4ae
12eeb26
9090999
a6f1973
0f68e7f
86504cc
85e0d96
86b682c
00f6347
a0ff186
923b6fe
79ec095
25b5301
4e137f3
278b277
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This uses the same log as below, also most of these parameters are not needed for restore. I imagine this step is just temporary until we refactor in a follow up PR though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This TargetDir is not correct. In my PR this worked because I would generate in the context of each test project, so TargetDir would point to the output of the test. Here you are running in the context of
helix.proj
so targetdir is the output directory of that one project. I think you need to instead generate into the test's directory, or somehow copy there.