[release/6.0.2xx] Propagate Interfaces annotation through Type.BaseType #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Interfaces annotation makes sure the type has all interfaces, meaning `GetInterfaces` reflection call will work on it. That means that all interfaces of the base type are also preserved, so the `Interfaces` annotation should be propagated to the base type as well.
MichalStrehovsky
approved these changes
Jan 4, 2022
agocke
reviewed
Jan 6, 2022
| @@ -1294,6 +1294,9 @@ public override bool HandleCall (MethodBody callingMethodBody, MethodReference c | |||
|
|
|||
| if (dynamicallyAccessedMemberNode.DynamicallyAccessedMemberTypes.HasFlag (DynamicallyAccessedMemberTypes.PublicProperties)) | |||
| propagatedMemberTypes |= DynamicallyAccessedMemberTypes.PublicProperties; | |||
|
|
|||
| if (dynamicallyAccessedMemberNode.DynamicallyAccessedMemberTypes.HasFlag (DynamicallyAccessedMemberTypes.Interfaces)) | |||
| propagatedMemberTypes |= DynamicallyAccessedMemberTypes.Interfaces; | |||
There was a problem hiding this comment.
Consider creating a mask here and &'ing, instead of checking each flag individually.
There was a problem hiding this comment.
Also, whether inclusion of exclusion is preferred, i.e. if we forget to update this, would we prefer to propagate more or less?
agocke
approved these changes
Jan 6, 2022
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
…pe (dotnet/linker#2476) The Interfaces annotation makes sure the type has all interfaces, meaning `GetInterfaces` reflection call will work on it. That means that all interfaces of the base type are also preserved, so the `Interfaces` annotation should be propagated to the base type as well. Commit migrated from dotnet/linker@5b33e3a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Interfaces annotation makes sure the type has all interfaces, meaning
GetInterfacesreflection call will work on it. That means that all interfaces of the base type are also preserved, so theInterfacesannotation should be propagated to the base type as well.Fixes #2473.