[release/6.0.2xx] Fix marking of nested type forwarders #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otnet#2372) The problematic scenario is if there's a "copy" assembly with a forwarder to a "link" assembly with a forwarder. The forwarder is for a nested class. Test for dotnet#2359. Also improved the test infra to print out errors from ilasm if they happen.
When create a type reference for the target of a type forwarder, if the type forwarder is for a nested type, we have to build a whole tree of type references for all of the declaring types and not just the final nested type. Enabled tests which were already added for this case (and fixed a bug in them)
|
Approved in email |
agocke
added a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
…ers6 [release/6.0.2xx] Fix marking of nested type forwarders Commit migrated from dotnet/linker@4e27b85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #2385
Fixes marking of nested type forwarders.
Part of #2359.
Customer Impact
Trimmer incorrectly removes type forwarders for nested type in some cases, breaking the application. One such impacted assembly is
Azure.ResourceManager.dll(from Azure's NuGet package).Testing
Added targeted test to the infrastructure. Validated that the change fixes the reported problem on a provided sample app.
Risk
Low. Before the change some nested type references were incorrect and Cecil would fail to resolve them effectively ignoring them in the process. After the change the nested type references are correctly created and Cecil can correctly resolve them, leading to including them in the output.