Nullable annotations part 1 #2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable nullable annotations for LinkContext and the XML processing classes.
marek-safar
reviewed
Sep 3, 2021
vitek-karas
approved these changes
Sep 3, 2021
- Use null check instead of assert - Add NotNullWhen annotation
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
* Nullable annotations part 1 Enable nullable annotations for LinkContext and the XML processing classes. Commit migrated from dotnet/linker@39505a8
sbomer
added a commit
to dotnet/runtime
that referenced
this pull request
Jun 19, 2024
The resolution cache is shared between `Resolve` and `TryResolve`, so we should call `ReportUnresolved` from `Resolve` when we see a cached null result (that could have been cached during `TryResolve`). Should make no difference to supported scenarios because we always run with `IgnoreUnresolved` `true`. This was regressed in dotnet/linker#2253. --------- Co-authored-by: Jackson Schuster <36744439+jtschuster@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable nullable annotations for LinkContext and the XML processing classes. I chose these as a starting point for no reason in particular, except that they produced a lot of warnings. Also includes other small fixes for things I noticed. In particular PTAL at the removed
ReportUnresolvedcalls inLinkContext.Resolve- those looked like they were producing redundant warnings for cachednullresults.