Fix order of custom steps #2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitek-karas
approved these changes
Jun 4, 2021
marek-safar
approved these changes
Jun 4, 2021
jonathanpeppers
added a commit
to dotnet/android
that referenced
this pull request
Jun 7, 2021
Context: dotnet/linker#2082 Fixes: #5997 Otherwise we are getting a `RemoveDesigner` test failure that looks like it is related: RemoveDesigner All Nested Resource Types should be removed. Expected: 0 But was: 5
jonpryor
added a commit
to dotnet/android
that referenced
this pull request
Jun 8, 2021
Fixes: #5997 Context: dotnet/linker#2082 Changes: dotnet/installer@46b17bd...c83bef2 Changes: dotnet/linker@50901f9...21df7db Changes: dotnet/runtime@6e5f722...5b8e178 Update the `*.apkdesc` files; looks like `libmonosgen-2.0.so` increased in size by ~20KB. Update the `@(_TrimmerCustomSteps)` ordering so that we use { RemoveResourceDesignerStep, GetAssembliesStep } instead of { GetAssembliesStep, RemoveResourceDesignerStep }. This change is needed because of dotnet/linker#2082. Otherwise we get a `RemoveDesigner` test failure that looks like it is related: RemoveDesigner All Nested Resource Types should be removed. Expected: 0 But was: 5 Co-authored-by: Jonathan Pryor <jonpryor@vt.edu> Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>
sbomer
added a commit
to dotnet/macios
that referenced
this pull request
Jun 18, 2021
In response to dotnet/linker#2082
rolfbjarne
pushed a commit
to dotnet/macios
that referenced
this pull request
Jun 22, 2021
In response to dotnet/linker#2082
rolfbjarne
added a commit
to dotnet/macios
that referenced
this pull request
Jun 28, 2021
* Update dependencies from https://github.com/dotnet/installer build 20210606.2 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.6.21280.2 -> To Version 6.0.100-preview.6.21306.2 Dependency coherency updates Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.6.21277.2 -> To Version 6.0.100-preview.6.21304.2 (parent: Microsoft.Dotnet.Sdk.Internal * Update dependencies from https://github.com/dotnet/installer build 20210613.2 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.6.21280.2 -> To Version 6.0.100-preview.6.21313.2 Dependency coherency updates Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.6.21277.2 -> To Version 6.0.100-preview.6.21304.2 (parent: Microsoft.Dotnet.Sdk.Internal * Update dependencies from https://github.com/dotnet/installer build 20210615.23 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.6.21280.2 -> To Version 6.0.100-preview.6.21315.23 Dependency coherency updates Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.6.21277.2 -> To Version 6.0.100-preview.6.21304.2 (parent: Microsoft.Dotnet.Sdk.Internal * Fix custom step order In response to dotnet/linker#2082 * Update dependencies from https://github.com/dotnet/installer build 20210620.4 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.6.21280.2 -> To Version 6.0.100-preview.7.21320.4 Dependency coherency updates Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.6.21277.2 -> To Version 6.0.100-preview.6.21317.4 (parent: Microsoft.Dotnet.Sdk.Internal * Update dependencies from https://github.com/dotnet/installer build 20210621.2 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.6.21280.2 -> To Version 6.0.100-preview.7.21321.2 Dependency coherency updates Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.6.21277.2 -> To Version 6.0.100-preview.6.21317.4 (parent: Microsoft.Dotnet.Sdk.Internal * Remove unnecessary workaround. * [dotnet] Update our code to get the path to the AOT compiler. Fixes #11905. * [dotnet] Remove another workaround for runtime packs doing the wrong thing. * Update dependencies from https://github.com/dotnet/installer build 20210622.1 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.6.21280.2 -> To Version 6.0.100-preview.7.21322.1 Dependency coherency updates Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.6.21277.2 -> To Version 6.0.100-preview.6.21321.1 (parent: Microsoft.Dotnet.Sdk.Internal * Update dependencies from https://github.com/dotnet/installer build 20210622.8 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.6.21280.2 -> To Version 6.0.100-preview.7.21322.8 Dependency coherency updates Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.6.21277.2 -> To Version 6.0.100-preview.6.21321.1 (parent: Microsoft.Dotnet.Sdk.Internal * Update dependencies from https://github.com/dotnet/installer build 20210623.2 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.6.21280.2 -> To Version 6.0.100-preview.7.21323.2 Dependency coherency updates Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.6.21277.2 -> To Version 6.0.100-preview.6.21321.1 (parent: Microsoft.Dotnet.Sdk.Internal * Update dependencies from https://github.com/dotnet/installer build 20210623.11 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.6.21280.2 -> To Version 6.0.100-preview.7.21323.11 Dependency coherency updates Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.6.21277.2 -> To Version 6.0.100-preview.6.21321.1 (parent: Microsoft.Dotnet.Sdk.Internal * Update dependencies from https://github.com/dotnet/installer build 20210624.6 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.6.21280.2 -> To Version 6.0.100-preview.7.21324.6 Dependency coherency updates Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.6.21277.2 -> To Version 6.0.100-preview.6.21321.1 (parent: Microsoft.Dotnet.Sdk.Internal * [dotnet] Install the microsoft-net-runtime-maccatalyst workload as well. * Update dependencies from https://github.com/dotnet/installer build 20210625.1 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.6.21280.2 -> To Version 6.0.100-preview.7.21325.1 Dependency coherency updates Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.6.21277.2 -> To Version 6.0.100-preview.6.21321.1 (parent: Microsoft.Dotnet.Sdk.Internal * Update dependencies from https://github.com/dotnet/installer build 20210626.4 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.6.21280.2 -> To Version 6.0.100-preview.7.21326.4 Dependency coherency updates Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.6.21277.2 -> To Version 6.0.100-preview.6.21322.1 (parent: Microsoft.Dotnet.Sdk.Internal Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Sven Boemer <sbomer@gmail.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
rolfbjarne
added a commit
to dotnet/macios
that referenced
this pull request
Jun 29, 2021
…11989) * Update dependencies from https://github.com/dotnet/installer build 20210620.7 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.6.21280.2 -> To Version 6.0.100-preview.6.21320.7 Dependency coherency updates Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.6.21277.2 -> To Version 6.0.100-preview.6.21314.2 (parent: Microsoft.Dotnet.Sdk.Internal * Remove unnecessary workaround. * Update dependencies from https://github.com/dotnet/installer build 20210621.13 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.6.21280.2 -> To Version 6.0.100-preview.6.21321.13 Dependency coherency updates Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.6.21277.2 -> To Version 6.0.100-preview.6.21314.2 (parent: Microsoft.Dotnet.Sdk.Internal * Fix custom step order In response to dotnet/linker#2082 * Update dependencies from https://github.com/dotnet/installer build 20210623.1 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.6.21280.2 -> To Version 6.0.100-preview.6.21323.1 Dependency coherency updates Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.6.21277.2 -> To Version 6.0.100-preview.6.21314.2 (parent: Microsoft.Dotnet.Sdk.Internal * Update dependencies from https://github.com/dotnet/installer build 20210623.12 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.6.21280.2 -> To Version 6.0.100-preview.6.21323.12 Dependency coherency updates Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.6.21277.2 -> To Version 6.0.100-preview.6.21314.2 (parent: Microsoft.Dotnet.Sdk.Internal * Update dependencies from https://github.com/dotnet/installer build 20210624.1 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.6.21280.2 -> To Version 6.0.100-preview.6.21324.1 Dependency coherency updates Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.6.21277.2 -> To Version 6.0.100-preview.6.21314.2 (parent: Microsoft.Dotnet.Sdk.Internal * Update dependencies from https://github.com/dotnet/installer build 20210624.9 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.6.21280.2 -> To Version 6.0.100-preview.6.21324.9 Dependency coherency updates Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.6.21277.2 -> To Version 6.0.100-preview.6.21314.2 (parent: Microsoft.Dotnet.Sdk.Internal * [dotnet] Install the microsoft-net-runtime-maccatalyst workload as well. * Update dependencies from https://github.com/dotnet/installer build 20210625.10 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.6.21280.2 -> To Version 6.0.100-preview.6.21325.10 Dependency coherency updates Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.6.21277.2 -> To Version 6.0.100-preview.6.21314.2 (parent: Microsoft.Dotnet.Sdk.Internal * [dotnet] Update our code to get the path to the AOT compiler. Fixes #11905. * Update dependencies from https://github.com/dotnet/installer build 20210628.1 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.6.21280.2 -> To Version 6.0.100-preview.6.21328.1 Dependency coherency updates Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.6.21277.2 -> To Version 6.0.100-preview.6.21314.2 (parent: Microsoft.Dotnet.Sdk.Internal Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: Sven Boemer <sbomer@gmail.com>
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
Commit migrated from dotnet/linker@21df7db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the issues I hit in dotnet/macios#11739 was caused by the custom steps being processed backwards. This fixes the order so they're processed in the order specified.
It's unfortunately still easy to get this wrong - I filed #2081 to track it.