Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sdk folder path in linker.tasks pkg #1847

Merged
merged 2 commits into from
Feb 24, 2021
Merged

Fix Sdk folder path in linker.tasks pkg #1847

merged 2 commits into from
Feb 24, 2021

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Feb 24, 2021

The PackageType was missing to indicate that the package is an msbuild sdk package, and the Sdk folder should start with a capital S. Hopefully that fixes the issue that we observed.

@ViktorHofer ViktorHofer self-assigned this Feb 24, 2021
Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which issue are you referring to - the sdk linker updates?

Other than the question about PackageType, LGTM.

@ViktorHofer
Copy link
Member Author

Which issue are you referring to - the sdk linker updates?

Yeah, sorry, this one: dotnet/sdk#15955 (comment)

@marek-safar marek-safar merged commit 43ba0de into main Feb 24, 2021
@marek-safar marek-safar deleted the FixSdkPkgResolve branch February 24, 2021 08:42
agocke pushed a commit to dotnet/runtime that referenced this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants