Update arcade and add support for --build-tests switch #18464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the change of DotNetBuildSkipTests to DotNetBuildTests, update arcade in the VMR and corresponding usages. Introduce control in the build scripts.
|
I haven't tried this yet in my local repo so hold on check-in please. |
ViktorHofer
approved these changes
Jan 31, 2024
ViktorHofer
reviewed
Jan 31, 2024
src/SourceBuild/content/build.sh
Outdated
| @@ -34,6 +34,7 @@ usage() | |||
| echo "" | |||
|
|
|||
| echo "Advanced settings:" | |||
| echo " --build-tests Build repository tests. May not be supported with --source-only" | |||
There was a problem hiding this comment.
The name might be misleading as it implies that it's an action but it actually is an argument. I.e. people might think that build.sh --build-tests will only build the tests but that isn't true.
ViktorHofer
reviewed
Jan 31, 2024
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
MichaelSimons
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the change of DotNetBuildSkipTests to DotNetBuildTests, update arcade in the VMR and corresponding usages. Introduce control in the build scripts.