Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass CrossBuild to inner builds #17972

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Conversation

jtschuster
Copy link
Member

@jtschuster jtschuster commented Dec 14, 2023

The msbuild changes necessary to enable cross-arch VMR builds (#17967). Not necessary if the pipeline adds the changes to the pipeline VMR build.

For cross-arch VMR builds, we disabled crossgen and ilc, and check DotnetBuildVertical and CrossBuild properties for the condition. Until we can get those building properly, we should pass CrossBuild from the outer build to the inner builds to make sure the checks work.

Part of dotnet/source-build#3698

@jtschuster jtschuster marked this pull request as ready for review December 14, 2023 16:24
@jtschuster jtschuster requested a review from a team as a code owner December 14, 2023 16:24
@jtschuster jtschuster merged commit f15f186 into dotnet:main Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants