Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Onboard runtime-portable and runtime #13770

Merged
merged 10 commits into from
May 13, 2022
Merged

Conversation

lbussell
Copy link

@lbussell lbussell commented May 4, 2022

Needs two patches. I have not submitted a backport PR yet because I would like to get both runtime-portable and runtime working, and submit one PR for both. I'm submitting this now to run it through CI as a sanity check.

@lbussell lbussell changed the title [main] Onboard runtime-portable [main] Onboard runtime-portable and runtime May 5, 2022
@lbussell
Copy link
Author

lbussell commented May 9, 2022

Status: the current runtime commit in installer contains my changes, so I will update this PR to remove the unnecessary patch. dotnet/runtime#67771 has just been merged, so once it flows in, runtime will require no patches and I will update this and request review.

Update 5/11: still waiting, current commit is https://github.com/dotnet/runtime/blob/3e5517beb897faf4592d23f036446561da1e5c23/Directory.Build.props#L56

@MichaelSimons
Copy link
Member

@lbussell - I think we should consider checking in a patch for the backported fix so that we can unblock other work. We need to update previous source build and it would be nice to have the runtime packages in it to avoid introducing a tremendous amount of prebuilts. What do you think?

@lbussell
Copy link
Author

I think we should consider checking in a patch for the backported fix so that we can unblock other work.

@MichaelSimons I think this is a good idea, I will work on it.

@lbussell lbussell marked this pull request as ready for review May 12, 2022 18:39
@lbussell lbussell requested a review from a team as a code owner May 12, 2022 18:39
@lbussell lbussell merged commit 59df269 into dotnet:main May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants