-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add tests back to the jenkins PR test script #888
Conversation
Hi @TyOverby, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
Hey Ty -- do you want this pr to stay open, or should I pull it? |
@KevinRansom Keep it open until I can get all the tests to pass! |
@enricosada Ty took over that work item. |
Didnt see he is a ms, i was thinking someone from community |
Added WIP to title until PR is ready |
@dotnet-bot test this please |
@dotnet-bot test Windows_NT Debug please |
@dotnet-bot test this please |
1 similar comment
@dotnet-bot test this please |
@@ -82,6 +82,7 @@ vsintegration/src/vs/FsPkgs/FSharp.Project/FS/FSharp.ProjectSystem.FSharp.fsi | |||
vsintegration/src/vs/FsPkgs/FSharp.Project/FS/ctofiles/ | |||
tests/fsharpqa/Source/CodeGen/EmittedIL/QueryExpressionStepping/Utils.dll | |||
tests/fsharpqa/Source/CodeGen/EmittedIL/ComputationExpressions/ComputationExprLibrary.dll | |||
tests\nunit3args.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can this have the same forward slashes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.gitignore is used also by other os.
the path separator is /
on .gitignore
so, pls fix it @TyOverby
@TyOverby thanks Kevin |
The way this PR will work is that I'm going to enable the test suites one by one and fix issues until they all pass.
I'll use this PR in order to test the PR tests.