Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add tests back to the jenkins PR test script #888

Closed
wants to merge 5 commits into from

Conversation

TyOverby
Copy link

The way this PR will work is that I'm going to enable the test suites one by one and fix issues until they all pass.

I'll use this PR in order to test the PR tests.

@msftclas
Copy link

Hi @TyOverby, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Ty Overby). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@KevinRansom
Copy link
Member

Hey Ty -- do you want this pr to stay open, or should I pull it?

@TyOverby
Copy link
Author

@KevinRansom Keep it open until I can get all the tests to pass!

@enricosada
Copy link
Contributor

@TyOverby i think @otawfik-ms it's doing that too. Or maybe not. @otawfik-ms ?
ref #859

@OmarTawfik
Copy link
Contributor

@enricosada Ty took over that work item.

@enricosada
Copy link
Contributor

Didnt see he is a ms, i was thinking someone from community

@dsyme dsyme changed the title Add tests back to the jenkins PR test script [WIP] Add tests back to the jenkins PR test script Jan 27, 2016
@dsyme
Copy link
Contributor

dsyme commented Jan 27, 2016

Added WIP to title until PR is ready

@TyOverby
Copy link
Author

@dotnet-bot test this please

@TyOverby
Copy link
Author

@dotnet-bot test Windows_NT Debug please

@TyOverby
Copy link
Author

@dotnet-bot test this please

1 similar comment
@TyOverby
Copy link
Author

@dotnet-bot test this please

@@ -82,6 +82,7 @@ vsintegration/src/vs/FsPkgs/FSharp.Project/FS/FSharp.ProjectSystem.FSharp.fsi
vsintegration/src/vs/FsPkgs/FSharp.Project/FS/ctofiles/
tests/fsharpqa/Source/CodeGen/EmittedIL/QueryExpressionStepping/Utils.dll
tests/fsharpqa/Source/CodeGen/EmittedIL/ComputationExpressions/ComputationExprLibrary.dll
tests\nunit3args.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can this have the same forward slashes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.gitignore is used also by other os.
the path separator is / on .gitignore
so, pls fix it @TyOverby

@KevinRansom
Copy link
Member

@TyOverby
I took care of this mate,

thanks

Kevin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants