Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate suggestions in unit tests and move some tests #7251

Merged
merged 10 commits into from
Aug 2, 2019
Merged

Activate suggestions in unit tests and move some tests #7251

merged 10 commits into from
Aug 2, 2019

Conversation

forki
Copy link
Contributor

@forki forki commented Jul 18, 2019

No description provided.

@forki forki closed this Jul 18, 2019
@forki forki reopened this Jul 18, 2019
@forki
Copy link
Contributor Author

forki commented Jul 18, 2019

@cartermp @KevinRansom somehow CI is not starting

@KevinRansom
Copy link
Member

Well have to wait until the morning i'm afraid.

@forki forki mentioned this pull request Jul 18, 2019
Closed
@forki forki closed this Jul 18, 2019
@forki forki reopened this Jul 18, 2019
@forki forki closed this Jul 19, 2019
@forki forki reopened this Jul 19, 2019
@cartermp
Copy link
Contributor

CI's back up

@forki forki closed this Jul 19, 2019
@forki forki reopened this Jul 19, 2019
@KevinRansom KevinRansom mentioned this pull request Jul 21, 2019
Merged
@KevinRansom KevinRansom reopened this Jul 22, 2019
@forki forki closed this Jul 27, 2019
@forki forki reopened this Jul 27, 2019
@forki
Merge branch 'master' of github.com:MecuSorin/fsharp into patch-50
a69752c 
# Conflicts:
#	tests/fsharpqa/Source/Warnings/env.lst
@forki forki closed this Jul 29, 2019
@forki forki reopened this Jul 29, 2019
MecuSorin
MecuSorin reviewed Jul 30, 2019
View reviewed changes
tests/fsharp/Compiler/ErrorMessages/SuggestionsTests.fs
FSharpErrorSeverity.Error
39
(2, 48, 2, 53)
"The type 'int11' is not defined. Maybe you want one of the following:\r\n int16\r\n int16`1\r\n int8\r\n uint16\r\n int"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

int16`1 is correct?

@forki forki changed the title [WIP] Try to activate suggestions in unit tests Try to activate suggestions in unit tests Jul 30, 2019
@forki
Copy link
Contributor Author

forki commented Jul 30, 2019

this is ready

@forki forki changed the title Try to activate suggestions in unit tests Activate suggestions in unit tests and move some tests Jul 30, 2019
@forki
Copy link
Contributor Author

forki commented Aug 2, 2019

all green

@KevinRansom
Copy link
Member

Thanks for this.

@KevinRansom KevinRansom merged commit 7c7a87b into dotnet:master Aug 2, 2019
@forki forki deleted the patch-50 branch August 2, 2019 06:10
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
@forki @nosami
Activate suggestions in unit tests and move some tests (dotnet#7251)
39545ab 
* Moved Suggestion Tests over to NUnit

* Try to activate suggestions in unit tests

* Fix suggestion tests

* Fix suggestion tests

* Fix suggestion tests

* Fix suggestion tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MecuSorin MecuSorin MecuSorin left review comments

@KevinRansom KevinRansom KevinRansom approved these changes

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@forki @KevinRansom @cartermp @MecuSorin