Fix #nowarn "2003" not working - #3139 #4480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make sure the warning is triggered always (not only when AssemblyVersionAttribute is present) - Make sure warning can be disabled via #nowarn 2003 - Include the correct range of the problematic string
|
Seems like Should we fix that here? |
|
the ubuntu failure is not related, seems like nuget is on vacation this weekend |
|
@dotnet-bot Test Ubuntu16.04 Release_default Build please |
matthid
commented
Mar 12, 2018
|
@dsyme should be use a |
|
@dsyme OK I got it working again with the new message :) |
|
@dsyme Is there still something blocked on my side? At least initially it looked simple enough |
dsyme
approved these changes
Apr 13, 2018
|
@matthid Thank you for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3139, by moving the warning emit of the warning into the type-checking phase. In detail the behavior changes are:
AssemblyVersionAttributeis present)#nowarn "2003"This means now warnings are emitted as:
AssemblyInfo.fs(5,38): warning FS2003: An System.Reflection.AssemblyVersionAttribute specified version '5.0.0asdas', but this value is invalid and has been ignoredwhile previously they did not contain any range information
warning FS2003: An System.Reflection.AssemblyVersionAttribute specified version '5.0.0asdas', but this value is invalid and has been ignoredAlso the ordering of the warnings might have changed. In order to compensate for the changed tests in
ProductVersion.fsI added now ones intests/fsharp/tests.fs.