Enable OpenTelemetry for Desktop target in xUnit tests #18233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ No release notes required |
|
Nice job @majocha! If you have a minute, could you share some Jaeger telemetry from tests, how it looks like right now on your machine? |
|
Sure! This is after some more clean-up that is beyond scope of this PR. Currently This is with Jaeger v2 running in docker. |
|
Nice! Yeah running Jaeger in docker in what we usually do. Good stuff, we can have this in and reduce noise separately. |
psfinaki
approved these changes
Jan 14, 2025
KevinRansom
approved these changes
Jan 14, 2025
T-Gro
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out building trace provider involves some assemblies being dynamically loaded. That's what kept failing previously.
We do install an assembly resolver in the app domain for desktop target but it was installed later than the call to
CreateTracerProviderBuilder. In effect Otel couldn't load some assemblies during startup. With this PR the call toAssemblyResolver.addResolverhappens earlier.