Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix one test #18072

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Fix one test #18072

merged 4 commits into from
Dec 4, 2024

Conversation

majocha
Copy link
Contributor

@majocha majocha commented Nov 27, 2024

Description

error on one workflow should cancel all others test` became flaky after my changes.
This became very apparent when running tests in parallel in CI.

The mistake was to rely on Async.OnCancel to detect cancellation inside the computation. This is absolutely unreliable because the computation can check for cancellation before Async.OnCancel manages to register its callback. Even inside Async.OnCancel implementation, there's a bind that will check cancellation and prevent the callback from executing.

Checklist

  • Ran locally a few thousand parallel iterations to make sure this is good.

@majocha majocha requested a review from a team as a code owner November 27, 2024 15:12
Copy link
Contributor

✅ No release notes required

@vzarytovskii
Copy link
Member

vzarytovskii commented Nov 27, 2024

image

^ story of my life

@majocha
Copy link
Contributor Author

majocha commented Nov 27, 2024

The failing test here is unrelated 😄 and depends on another fix here: #18074

@majocha majocha closed this Nov 28, 2024
@majocha majocha reopened this Nov 28, 2024
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks :)

@psfinaki psfinaki merged commit b7ba9f6 into dotnet:main Dec 4, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants