Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
error on one workflow should cancel all others
test` became flaky after my changes.This became very apparent when running tests in parallel in CI.
The mistake was to rely on
Async.OnCancel
to detect cancellation inside the computation. This is absolutely unreliable because the computation can check for cancellation beforeAsync.OnCancel
manages to register its callback. Even insideAsync.OnCancel
implementation, there's a bind that will check cancellation and prevent the callback from executing.Checklist