-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use library-packs also when RestoreAdditionalProjectSources is explicitly set. #18000
Conversation
…itly set. library-packs are SDK features that implemented using bundled NuGet package files. When a user sets RestoreAdditionalProjectSources, these features must remain available. To disable library-packs features, a user may set DisableImplicitLibraryPacksFolder.
✅ No release notes required |
@tmds --- I think I may need a little more context. I am unfamiliar with TreatAsLocalProperty except as a mechanism for disallowing value property changes from the command line. Am I correct in assuming that: So what does the change accomplish other than disabling the ability to : dotnet build myproj.fsproj /p:RestoreAdditionalProjectSources=SomeOtherUriOrPath Is that the scenario you are hoping to block? Thanks Kevin |
By adding the See dotnet/sdk#44547 (comment) for some more context. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this.
This reverts commit 98403c7.
library-packs are SDK features that implemented using bundled NuGet package files.
When a user sets RestoreAdditionalProjectSources, these features must remain available.
To disable library-packs features, a user may set DisableImplicitLibraryPacksFolder.
Fixes dotnet/sdk#44547.
@dsplaisted @nkolev92 @baronfel ptal.