Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main to release/dev17.12 #17636

Merged
merged 10 commits into from
Aug 30, 2024

Conversation

dotnet-bot
Copy link
Contributor

This is an automatically generated pull request from main into release/dev17.12.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout -t upstream/merges/main-to-release/dev17.12
git reset --hard upstream/release/dev17.12
git merge upstream/main
# Fix merge conflicts
git commit
git push upstream merges/main-to-release/dev17.12 --force

vzarytovskii and others added 9 commits August 28, 2024 03:20
…ence-packages build 20240826.2 (#17616)

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.0-alpha.1.24421.1 -> To Version 10.0.0-alpha.1.24426.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Keep extra parens around unit & tuples in arg pats

* There are several scenarios where it is impossible to know whether the
  parentheses are required, or whethery they may affect compilation, by
  looking only at the syntax.
…826.3 (#17615)

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 9.0.0-beta.24423.2 -> To Version 9.0.0-beta.24426.3

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
* Change realSig to be `false` by default

* Adjust tests

* fantomas'd

* quickinfo test

* Update Tests.LanguageService.QuickInfo.fs

---------

Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>
@dotnet-bot dotnet-bot requested a review from a team as a code owner August 30, 2024 00:05
@dotnet-bot dotnet-bot force-pushed the merges/main-to-release/dev17.12 branch from 76bbdcf to dcf7db7 Compare August 30, 2024 00:05
Copy link
Contributor

❗ Release notes required


✅ Found changes and release notes in following paths:

Warning

No PR link found in some release notes, please consider adding it.

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.100.md No current pull request URL (#17636) found, please consider adding it

1 similar comment
Copy link
Contributor

❗ Release notes required


✅ Found changes and release notes in following paths:

Warning

No PR link found in some release notes, please consider adding it.

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.100.md No current pull request URL (#17636) found, please consider adding it

@vzarytovskii vzarytovskii merged commit 47b2104 into release/dev17.12 Aug 30, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants