Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser: recover on missing union case field types #17455

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Parser: recover on missing union case field types #17455

merged 2 commits into from
Aug 2, 2024

Conversation

auduchinok
Copy link
Member

Continuation of #17452. Add recovery for unfinished union case fields:

type U =
    | A of i:
type U =
    | A of i: * int

@auduchinok auduchinok requested a review from a team as a code owner July 29, 2024 09:15
@auduchinok auduchinok force-pushed the parser-unionCaseFieldType branch from 43ecff6 to b288082 Compare July 29, 2024 09:15
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 29, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.100.md

@auduchinok auduchinok changed the title Parser: recover on missing union case field type Parser: recover on missing union case field types Jul 29, 2024
@auduchinok auduchinok force-pushed the parser-unionCaseFieldType branch from b288082 to 2f433d3 Compare August 1, 2024 13:18
@auduchinok auduchinok closed this Aug 1, 2024
@auduchinok auduchinok reopened this Aug 1, 2024
@psfinaki
Copy link
Member

psfinaki commented Aug 1, 2024

/azp run

@psfinaki psfinaki enabled auto-merge (squash) August 1, 2024 16:58
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki
Copy link
Member

psfinaki commented Aug 2, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki psfinaki merged commit d8e2f21 into dotnet:main Aug 2, 2024
32 checks passed
@auduchinok auduchinok deleted the parser-unionCaseFieldType branch August 2, 2024 13:33
This was referenced Aug 13, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

@T-Gro T-Gro T-Gro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@auduchinok @psfinaki @T-Gro