Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to .NET9 #17426

Merged
merged 19 commits into from
Jul 23, 2024
Merged

Default to .NET9 #17426

merged 19 commits into from
Jul 23, 2024

Conversation

vzarytovskii
Copy link
Member

No description provided.

@vzarytovskii vzarytovskii added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Jul 22, 2024
@vzarytovskii vzarytovskii requested a review from a team as a code owner July 22, 2024 10:01
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@vzarytovskii
Copy link
Member Author

@dotnet/source-build-internal folks, now when I have updated to net9 by default, it seems that SB is failing with

/__w/1/s/.dotnet/sdk/9.0.100-preview.6.24328.19/Sdks/Microsoft.NET.Sdk/targets/Microsoft.PackageDependencyResolution.targets(266,5): error MSB4044: The "ResolvePackageAssets" task was not given a value for the required parameter "TargetFramework". [/__w/1/s/artifacts/source-build/self/src/buildtools/fslex/fslex.fsproj] [/__w/1/s/.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.24311.3/tools/Build.proj]
##[error].dotnet/sdk/9.0.100-preview.6.24328.19/Sdks/Microsoft.NET.Sdk/targets/Microsoft.PackageDependencyResolution.targets(266,5): error MSB4044: The "ResolvePackageAssets" task was not given a value for the required parameter "TargetFramework". [/__w/1/s/artifacts/source-build/self/src/buildtools/fslex/fslex.fsproj]

Do you happen to know what's wrong from the top of your head, before I started digging deeper? Is it arcade version/channel?

@vzarytovskii vzarytovskii requested a review from a team as a code owner July 22, 2024 10:37
@vzarytovskii
Copy link
Member Author

Ok, updating arcade fixed this particular issue, but now I'm getting new prebuilts:

##[error].packages/microsoft.dotnet.arcade.sdk/9.0.0-beta.24352.2/tools/SourceBuild/AfterSourceBuild.proj(81,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 8 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.DotNet.Arcade.Sdk.9.0.0-beta.24352.2
Microsoft.DotNet.Build.Tasks.Feed.9.0.0-beta.24352.2
Microsoft.DotNet.NuGetRepack.Tasks.9.0.0-beta.24352.2
Microsoft.DotNet.SourceBuild.Tasks.9.0.0-beta.24352.2
Microsoft.DotNet.XliffTasks.9.0.0-beta.24352.2

@dotnet/source-build-internal @ViktorHofer maybe you folks know if I should add them to baseline, or shall those be fixed elsewhere?

@ViktorHofer
Copy link
Member

@dotnet/source-build-internal @ViktorHofer maybe you folks know if I should add them to baseline, or shall those be fixed elsewhere?

You need to update the Version.Details.xml entries as well.

@vzarytovskii
Copy link
Member Author

@dotnet/source-build-internal @ViktorHofer maybe you folks know if I should add them to baseline, or shall those be fixed elsewhere?

You need to update the Version.Details.xml entries as well.

Thanks, will check it out, not sure we have them explicitly already.

@ViktorHofer
Copy link
Member

It might be sufficient to just bump this one: https://github.com/vzarytovskii/fsharp/blob/cf25ed0d0a774f663ae024b984c188aa951688c0/eng/Version.Details.xml#L45-L48

and remove the xliff entries.

ViktorHofer
ViktorHofer reviewed Jul 22, 2024
View reviewed changes
eng/Version.Details.xml
Comment on lines +55 to +61
<Dependency Name="Microsoft.DotNet.XliffTasks" Version="1.0.0-beta.23475.1"
CoherentParentDependency="Microsoft.DotNet.Arcade.Sdk">
<Uri>https://github.com/dotnet/xliff-tasks</Uri>
<Sha>73f0850939d96131c28cf6ea6ee5aacb4da0083a</Sha>
</Dependency>
<!-- Intermediate is necessary for source build. -->
<Dependency Name="Microsoft.SourceBuild.Intermediate.xliff-tasks" Version="1.0.0-beta.23475.1" CoherentParentDependency="Microsoft.DotNet.Arcade.Sdk">
<Dependency Name="Microsoft.SourceBuild.Intermediate.xliff-tasks" Version="1.0.0-beta.23475.1">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added xliff-tasks back, maybe by accident?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, probably copied from roslyn by accident. Will remove it later.

@vzarytovskii
Copy link
Member Author

If it's green, I'm going to merge it + prepare 17.12 and insertions, so we have a chance of having a build today.

@vzarytovskii vzarytovskii merged commit 08f8476 into dotnet:main Jul 23, 2024
28 of 30 checks passed
@vzarytovskii vzarytovskii deleted the net9tfm branch July 23, 2024 10:40
This was referenced Jul 25, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Aug 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki left review comments

@ViktorHofer ViktorHofer ViktorHofer left review comments

Assignees
No one assigned
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vzarytovskii @ViktorHofer @psfinaki