Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser: recover on unfinished isConst patterns #17232

Merged
merged 10 commits into from
Sep 4, 2024

Conversation

auduchinok
Copy link
Member

Adds recovery for unfinished IsInstance patterns:

match () with
| :? T
match () with
| :?

@auduchinok auduchinok requested a review from a team as a code owner May 23, 2024 09:44
Copy link
Contributor

github-actions bot commented May 23, 2024

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.100.md

@auduchinok auduchinok force-pushed the parser-pat-isInst branch 2 times, most recently from fb2f108 to 7ecb6e1 Compare May 24, 2024 15:10
@auduchinok
Copy link
Member Author

This is ready.

@psfinaki
Copy link
Member

This is ready.

I think there are some baselines needing updates.

@auduchinok
Copy link
Member Author

This is ready.

@psfinaki
Copy link
Member

psfinaki commented Sep 3, 2024

@auduchinok thanks for getting back to this :)

@psfinaki psfinaki merged commit 5f936eb into dotnet:main Sep 4, 2024
30 checks passed
@auduchinok auduchinok deleted the parser-pat-isInst branch September 4, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants