Remove some dead code #17086
Merged
Remove some dead code #17086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
edgarfgp
reviewed
Apr 24, 2024
edgarfgp
approved these changes
Apr 24, 2024
psfinaki
approved these changes
Apr 25, 2024
abonie
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing some dead code guarded by a bunch of ifdefs, which we never set.
Not removing some of them:
-
NO_INLINE_IL_PARSERandFX_NO_WEAKTABLEare set by Fable,-
CHECK_LINE0_TYPESwe can use it for checking 0-based to 1-based line numbers transformation, and can be useful.-
CHECKINGandSTATISTICScan be used ad-hoc to debug ilreading-
LOGGING_GUIfor debugging fsi- I am not certain about
TRAIT_CONSTRAINT_CORRECTIONS, it seems like it should've been turned on in F# 6, but neither feature nor define exist or set, cc @dsyme