[VS] Consolidate Roslyn workspace and FCS #11694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er and OptionsManager
…as we do not need them anymore.
|
@KevinRansom @dsyme This is ready when the tests pass. |
|
Wonderful, it's passing :) |
dsyme
requested changes
Jun 23, 2021
|
|
||
| items.Add dataItem | ||
|
|
||
| d.ForEach(f) |
There was a problem hiding this comment.
Stylistically I'd prefer d.ForEach(fun dataItem -> ...) rather than using a local function. But that's unrelated to this PR
vsintegration/src/FSharp.Editor/CodeFix/AddMissingRecToMutuallyRecFunctions.fs
Show resolved
Hide resolved
vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs
Outdated
Show resolved
Hide resolved
|
@dsyme this is ready again. |
dsyme
reviewed
Jun 24, 2021
| ) = | ||
| inherit CodeFixProvider() | ||
| let fixableDiagnosticIds = ["FS0053"] | ||
| static let userOpName = "ProposeUpperCaseLabel" |
There was a problem hiding this comment.
Still some userOpName being dropped but I'll approve this as is
dsyme
approved these changes
Jun 24, 2021
| asyncMaybe { | ||
| let! sourceText = document.GetTextAsync() |> liftTaskAsync | ||
| let filePath = document.FilePath | ||
| let! symbol = document.TryFindFSharpLexerSymbolAsync(position, SymbolLookupKind.Greedy, false, false, nameof(FSharpDocumentHighlightsService.GetDocumentHighlights)) |
There was a problem hiding this comment.
Stylistically I think I prefer binding userOpName at the top of the scope like before but it's no big deal.
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
[VS] Consolidate Roslyn workspace and FCS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring PR for the most part.
I've been testing out the in-memory documents PR and it's a little unstable. We need the ability to unit test VS behavior reliably.
Currently, our VS tests do not even use
FSharpProjectOptionsManagerwhich I think it should as it plays an large role for VS (in the future, we may be able to get rid of it, but not now).So, this PR is to consolidate Rolsyn workspaces and FCS into one place called
WorkspaceExtensions.