-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Add type annotation to parameter" refactoring + remove dangling file lost in recent refactorings #10937
Conversation
A note: This only applies to parameters for now. Why? Because of
There are three alternatives I see here:
I don't really want to entertain any of them in this PR. I think this PR accomplishes the majority use case anyways. |
vsintegration/src/FSharp.Editor/Refactor/AddExplicitTypeToParameter.fs
Outdated
Show resolved
Hide resolved
20fdc36
to
dbc7407
Compare
b5d08dd
to
7502dcd
Compare
vsintegration/src/FSharp.Editor/Refactor/AddExplicitTypeToParameter.fs
Outdated
Show resolved
Hide resolved
Co-authored-by: Chet Husk <baronfel@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The tests are great.
…file lost in recent refactorings (dotnet#10937) Co-authored-by: Chet Husk <baronfel@users.noreply.github.com>
Quick sample of it so far: