-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Probably dangerous?] Fixes printing argument tuple name in a tooltip #10461
Conversation
Yep, already broke something that did not show on my machine because I was only using FCS, that's unfortunate. But well, kinda expected this kind of thing to happen. |
I think it has something to do with signature file generation based on the errors |
@cartermp seems like all of those failed tests are Azure related if I'm not wrong. |
Yep, it tried to download stuff and computer says no |
Restarting CI to get fresh failures since the build was discarded by CI |
@En3Tho this looks like it requires an updated baseline to proceed. |
@cartermp Actually I think this one should be closed as it is dangerous. This arity thing, which I fixed here has special meaning for the compiler on the next stage. So it's kinda ok to have this line for FCS (I'm actually using it in my private build), but surely not for FSC. I think there should be another way to save variable name information. Also, this doesn't cover value tuples anyway |
Sounds good. |
This tries to fix printing tuple name (#10441) like in this case:


before:
after:
or this:


before:
after:
or this:


before:
after:
Needs testing as it's goes way lower than Tooltip's creation