Merge branch 'main' into Fix16105

dotnet · Feb 26, 2024 · 0dd5895 · 0dd5895
2 parents 054fcc1 + bc3dd9f
commit 0dd5895
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/docs/release-notes/.FSharp.Compiler.Service/8.0.202.md b/docs/release-notes/.FSharp.Compiler.Service/8.0.202.md
@@ -1,3 +1,3 @@
 ### Fixed
 
-* `nameof Module` expressions and patterns are processed to link files in `--test:GraphBasedChecking`. ([PR #16570](https://github.com/dotnet/fsharp/pull/16570))
+`nameof Module` expressions and patterns are processed to link files in `--test:GraphBasedChecking`. ([PR #16570](https://github.com/dotnet/fsharp/pull/16570), [PR #16747](https://github.com/dotnet/fsharp/pull/16747))
diff --git a/tests/service/ProjectAnalysisTests.fs b/tests/service/ProjectAnalysisTests.fs
@@ -4655,7 +4655,7 @@ let callToOverload = B(5).Overload(4)
     let args = mkProjectCommandLineArgs (dllName, [])
 
 [<Test>]
-[<TestCase true>]
+// [<TestCase true>] // Flaky, reenable when stable
 [<TestCase false>]
 let ``Test project36 FSharpMemberOrFunctionOrValue.IsBaseValue`` useTransparentCompiler =
     let keepAssemblyContentsChecker = FSharpChecker.Create(keepAssemblyContents=true, useTransparentCompiler=useTransparentCompiler)
@@ -4672,7 +4672,7 @@ let ``Test project36 FSharpMemberOrFunctionOrValue.IsBaseValue`` useTransparentC
     |> fun baseSymbol -> shouldEqual true baseSymbol.IsBaseValue
 
 [<Test>]
-[<TestCase true>]
+// [<TestCase true>] // Flaky, reenable when stable
 [<TestCase false>]
 let ``Test project36 FSharpMemberOrFunctionOrValue.IsConstructorThisValue & IsMemberThisValue`` useTransparentCompiler =
     let keepAssemblyContentsChecker = FSharpChecker.Create(keepAssemblyContents=true, useTransparentCompiler=useTransparentCompiler)
@@ -4711,7 +4711,7 @@ let ``Test project36 FSharpMemberOrFunctionOrValue.IsConstructorThisValue & IsMe
     |> shouldEqual true
 
 [<Test>]
-[<TestCase true>]
+// [<TestCase true>] // Flaky, reenable when stable
 [<TestCase false>]
 let ``Test project36 FSharpMemberOrFunctionOrValue.LiteralValue`` useTransparentCompiler =
     let keepAssemblyContentsChecker = FSharpChecker.Create(keepAssemblyContents=true, useTransparentCompiler=useTransparentCompiler)
@@ -5329,7 +5329,7 @@ let foo (a: Foo): bool =
     let options = { checker.GetProjectOptionsFromCommandLineArgs (projFileName, args) with SourceFiles = fileNames }
 
 [<Test>]
-[<TestCase true>]
+// [<TestCase true>] // Flaky, reenable when stable
 [<TestCase false>]
 let ``Test typed AST for struct unions`` useTransparentCompiler = // See https://github.com/fsharp/FSharp.Compiler.Service/issues/756
     let keepAssemblyContentsChecker = FSharpChecker.Create(keepAssemblyContents=true, useTransparentCompiler=useTransparentCompiler)
@@ -5419,7 +5419,7 @@ let ``Test diagnostics with line directives ignored`` () =
 //------------------------------------------------------
 
 [<Test>]
-[<TestCase true>]
+// [<TestCase true>] // Flaky, reenable when stable
 [<TestCase false>]
 let ``ParseAndCheckFileResults contains ImplFile list if FSharpChecker is created with keepAssemblyContent flag set to true`` useTransparentCompiler =
 
@@ -5463,7 +5463,7 @@ type A(i:int) =
     | None -> failwith "declaration list is empty"
 
 [<Test>]
-[<TestCase true>]
+// [<TestCase true>] // Flaky, reenable when stable
 [<TestCase false>]
 let ``TryGetRecentCheckResultsForFile called with snapshot returns cached result after ParseAndCheckFile`` useTransparentCompiler =
     let fileName1 = Path.ChangeExtension(tryCreateTemporaryFileName (), ".fs")
@@ -5538,7 +5538,7 @@ let ``#4030, Incremental builder creation warnings`` (args, errorSeverities) =
 //------------------------------------------------------
 
 [<Test>]
-[<TestCase true>]
+// [<TestCase true>] // Flaky, reenable when stable
 [<TestCase false>]
 let ``Unused opens in rec module smoke test 1`` useTransparentCompiler =
 
@@ -5613,7 +5613,7 @@ type UseTheThings(i:int) =
     unusedOpensData |> shouldEqual expected
 
 [<Test>]
-[<TestCase true>]
+// [<TestCase true>] // Flaky, reenable when stable
 [<TestCase false>]
 let ``Unused opens in non rec module smoke test 1`` useTransparentCompiler =
 
@@ -5688,7 +5688,7 @@ type UseTheThings(i:int) =
     unusedOpensData |> shouldEqual expected
 
 [<Test>]
-[<TestCase true>]
+// [<TestCase true>] // Flaky, reenable when stable
 [<TestCase false>]
 let ``Unused opens smoke test auto open`` useTransparentCompiler =
 
@@ -5861,4 +5861,4 @@ module internal EmptyProject =
 let ``Empty source list produces error FS0207`` () =
     let results = checker.ParseAndCheckProject(EmptyProject.options) |> Async.RunImmediate
     results.Diagnostics.Length |> shouldEqual 1
-    results.Diagnostics[0].ErrorNumber |> shouldEqual 207
+    results.Diagnostics[0].ErrorNumber |> shouldEqual 207