Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for Workload Sets feature #42109

Merged
merged 33 commits into from
Aug 24, 2024
Merged

Documentation for Workload Sets feature #42109

merged 33 commits into from
Aug 24, 2024

Conversation

tdykstra
Copy link
Contributor

@tdykstra tdykstra commented Aug 12, 2024 •
edited by github-actions bot
Loading

@tdykstra tdykstra requested a review from a team as a code owner August 12, 2024 05:18
@dotnet-bot dotnet-bot added this to the August 2024 milestone Aug 12, 2024
@tdykstra tdykstra marked this pull request as draft August 12, 2024 05:19
@tdykstra tdykstra changed the title Documentation for Workload Sets feature WIP: Documentation for Workload Sets feature Aug 12, 2024
gewarren
gewarren reviewed Aug 15, 2024
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested hyphenating workload-set if it's used as an adjective. I want to link to this from the What's new once it's merged.

docs/core/tools/dotnet-workload-install.md Outdated Show resolved Hide resolved
docs/core/tools/dotnet-workload-install.md Outdated Show resolved Hide resolved
docs/core/tools/dotnet-workload-config.md Outdated Show resolved Hide resolved
docs/core/tools/dotnet-workload-config.md Show resolved Hide resolved
docs/core/tools/dotnet-workload-config.md Outdated Show resolved Hide resolved
docs/core/tools/dotnet-workload-sets.md Outdated Show resolved Hide resolved
docs/core/tools/dotnet-workload-sets.md Outdated Show resolved Hide resolved
docs/core/tools/dotnet-workload-sets.md Outdated Show resolved Hide resolved
docs/core/tools/dotnet-workload-sets.md Outdated Show resolved Hide resolved
docs/core/tools/dotnet-workload-sets.md Outdated Show resolved Hide resolved
tdykstra and others added 5 commits August 15, 2024 15:11
@tdykstra
draft
8a1edf8
@tdykstra
draft
bd637aa
@tdykstra
draft
c45a547
@tdykstra
draft
773f82f
@tdykstra @gewarren
Apply suggestions from code review
f188ad3 
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@tdykstra
Copy link
Contributor Author

Thanks for the review, @gewarren. I agree with the change to hyphenate workload-sets.

@tdykstra tdykstra marked this pull request as ready for review August 15, 2024 23:12
@tdykstra tdykstra requested a review from baronfel August 15, 2024 23:13
@tdykstra @marcpopMSFT
Apply suggestions from code review
26c8351 
Co-authored-by: Marc Paine <marcpop@microsoft.com>
@tdykstra tdykstra merged commit 4f7d70b into main Aug 24, 2024
8 checks passed
@tdykstra tdykstra deleted the workloadsets branch August 24, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren left review comments

@marcpopMSFT marcpopMSFT marcpopMSFT left review comments

@baronfel baronfel baronfel approved these changes

Assignees
No one assigned
Labels
dotnet-cli/subsvc dotnet-fundamentals/svc
Projects
None yet
Milestone
August 2024
Development

Successfully merging this pull request may close these issues.

[New article]: Documentation for Workload Sets feature
5 participants
@tdykstra @baronfel @marcpopMSFT @gewarren @dotnet-bot