Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Porting eBook #27512

Merged
merged 48 commits into from
Dec 14, 2021
Merged

Update Porting eBook #27512

merged 48 commits into from
Dec 14, 2021

Conversation

ardalis
Copy link
Contributor

@ardalis ardalis commented Dec 12, 2021

sync porting-ebook-net6 with main before reviewing

ardalis and others added 30 commits November 15, 2021 13:58
@ardalis @machielvisser
@IEvangelist @ArtyProf @BillWagner
Blazor ebook frontmatter (dotnet#27086)
0c1d11c 
* Update cs5001.md (dotnet#27080)

* Update cs5001.md

* Update docs/csharp/misc/cs5001.md

Co-authored-by: David Pine <david.pine@microsoft.com>

* Remove redundant nullable operator (dotnet#27023)

* Remove redundant nullable operator

Remove redundant nullable operator for reference type. String is a reference type and always nullable,

* Make undesired error more clear

Co-authored-by: Bill Wagner <wiwagn@microsoft.com>

Co-authored-by: Bill Wagner <wiwagn@microsoft.com>

* update version

* fix typo

Co-authored-by: Machiel visser <16868513+machielvisser@users.noreply.github.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: Artur Khutak <rd.artyrchik@gmail.com>
Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
@jakubkozera @IEvangelist
VS 2022 'preview' removed (dotnet#27070)
1f1e5bb
@mohamed-azhar @IEvangelist
Fixed Typo (dotnet#27072)
7d05463 
changed short description to shortDescription in the comments to avoid confusion.
@azure-sdk @IEvangelist
Update package index with latest published versions (dotnet#27083)
7475617
@wuyuansushen @IEvangelist
Update ExampleAsyncDisposable.cs (dotnet#27074)
522db4f
@IEvangelist @tdykstra
Details overloading == and != operators on the ValueObject type (…
45f3b2f 
…dotnet#27040)

* Add details about overloading == and != operators

* Apply suggestions from code review

Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>

Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
@enchant97 @IEvangelist
Fix text element count not starting at 1 (dotnet#27010)
d3dd722 
When the code sample `InsertNewlinesEveryTenTextElements` is run, the first newline is 11 characters long when it is meant to be 10. This commit fixes that by making the `textElementCount` start at 1.
@gewarren @IEvangelist
Update code analysis props for .NET 6 (dotnet#26880)
a227987
@azure-sdk @IEvangelist
Update package index with latest published versions (dotnet#27095)
56457d9
@adegeo @IEvangelist
Add link to Fedora .NET 6 tracking bug (dotnet#27091)
0d2c8d7 
* Update linux-fedora.md

* Update linux-fedora.md
@radrow @IEvangelist
Retitle Fact 1 (dotnet#27102)
08af11c 
Facts cannot be stated in an imperative form. Otherwise, I would call it a "tip".
@IEvangelist
Add the HTTP keyword to the expected list of available slug completio…
5e3f838 
…ns (dotnet#27104)
@IEvangelist
Address concerns about inconsistent code style and formatting (dotnet…
86db076 
…#27089)

* Code style

* Update usings.cs
@kendaleiv @IEvangelist
Code block fix (dotnet#27103)
e2d8bbb
@azure-sdk @IEvangelist
Update package index with latest published versions (dotnet#27105)
39961fa
@tdykstra @IEvangelist
Fix NETSDK error number (dotnet#27106)
34ee5a0
@gewarren @IEvangelist
Add more info to recommended actions (dotnet#27093)
0291f98
@gewarren @IEvangelist
Add note about .NET Framework (dotnet#27107)
7da65f5
@azure-sdk @IEvangelist
Update package index with latest published versions (dotnet#27108)
e25944b
@gewarren @IEvangelist
fix build suggestions (dotnet#27109)
33de384
@gewarren @IEvangelist
Add note about FTP (dotnet#27094)
35b4b0a
@BillWagner @IEvangelist
Add with-expressions to anonymous types (dotnet#27111)
13db9bb 
* Add with-expressions to anonymous types

Fixes dotnet#26770

With-expressions can be used with anonymous types.

* code review
@dependabot @IEvangelist
Bump Humanizer (dotnet#27124)
7d15439 
Bumps [Humanizer](https://github.com/Humanizr/Humanizer) from 2.11.10 to 2.13.14.
- [Release notes](https://github.com/Humanizr/Humanizer/releases)
- [Changelog](https://github.com/Humanizr/Humanizer/blob/main/release_notes.md)
- [Commits](Humanizr/Humanizer@v2.11.10...v2.13.14)

---
updated-dependencies:
- dependency-name: Humanizer
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@wuyuansushen @IEvangelist
Fix Dispose(bool) method overload in ConjunctiveDisposable pattern (d…
27f8137 
…otnet#27118)

* Update ExampleAsyncDisposable.cs

* Update ExampleConjunctiveDisposable.cs
@jeffhandley @IEvangelist
Add documentation for CA2255 (new in .NET 6) (dotnet#27096)
657431b 
* Add documentation for CA2255 (new in .NET 6)

* Address pr feedback
@jeffhandley @IEvangelist
Remove backticks from page metadata (dotnet#27114)
ff039e3
@azure-sdk @IEvangelist
Update package index with latest published versions (dotnet#27115)
9193947
@gewarren @IEvangelist
acrolinx (dotnet#27117)
1bf94fa
@scottaddie @IEvangelist
Restore the Azure for .NET devs tile (dotnet#27128)
b3ebcba
@IEvangelist
Update rabbitmq-event-bus-development-test-environment.md (dotnet#27134)
719a11a 
Fixes dotnet#27130
ardalis and others added 12 commits November 19, 2021 10:17
@dotnet-bot dotnet-bot added this to the December 2021 milestone Dec 12, 2021
@ardalis ardalis mentioned this pull request Dec 12, 2021
Closed
IEvangelist
IEvangelist requested changes Dec 13, 2021
View reviewed changes
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you @ardalis - I just have a few suggestions.

@IEvangelist
Copy link
Member

Additionally, @ardalis - there are two other issues that need to be addressed before merging:

  • Warning | Line 30 of
    docs/architecture/porting-existing-aspnet-apps/incremental-migration-strategies.md

    Invalid file link: '../../core/compatibility/6.0'.

  • Suggestion | Line 10 of
    docs/architecture/porting-existing-aspnet-apps/migrate-aspnet-core-2-1.md

    Absolute link 'https://docs.microsoft.com/lifecycle/products/microsoft-net-framework' will be broken in isolated environments. Replace with a relative link.

ardalis and others added 4 commits December 13, 2021 11:44
@ardalis @IEvangelist
Apply suggestions from code review
b62d718 
Co-authored-by: David Pine <david.pine@microsoft.com>
@ardalis @IEvangelist
Update docs/architecture/blazor-for-web-forms-developers/project-stru…
e332410 
…cture.md

Co-authored-by: David Pine <david.pine@microsoft.com>
@ardalis
fixing links
5c7c6d7
@ardalis
Merge branch 'ardalis/porting-ebook' of https://github.com/ardalis/do…
82b9f8a 
…cs-1 into ardalis/porting-ebook
@ardalis
Copy link
Contributor Author

ardalis commented Dec 13, 2021

I think it's all good now.

@IEvangelist IEvangelist merged commit 90d94d6 into dotnet:porting-ebook-net6 Dec 14, 2021
@IEvangelist IEvangelist mentioned this pull request Dec 14, 2021
Merged
@ardalis ardalis deleted the ardalis/porting-ebook branch February 2, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IEvangelist IEvangelist IEvangelist approved these changes

@danroth27 danroth27 Awaiting requested review from danroth27

@nishanil nishanil Awaiting requested review from nishanil

Assignees
No one assigned
Labels
blazor/subsvc dotnet-architecture/svc
Projects
None yet
Milestone
December 2021
Development

Successfully merging this pull request may close these issues.