Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernizing ebook frontmatter #27132

Conversation

ardalis
Copy link
Contributor

@ardalis ardalis commented Nov 17, 2021

Pull latest changes from master into mordernize-web-apps-ebook-net6 (sic) branch before doing this PR.

machielvisser and others added 30 commits November 15, 2021 07:31
* Update cs5001.md

* Update docs/csharp/misc/cs5001.md

Co-authored-by: David Pine <david.pine@microsoft.com>
* Remove redundant nullable operator

Remove redundant nullable operator for reference type. String is a reference type and always nullable,

* Make undesired error more clear

Co-authored-by: Bill Wagner <wiwagn@microsoft.com>

Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
changed short description to shortDescription in the comments to avoid confusion.
…dotnet#27040)

* Add details about overloading == and != operators

* Apply suggestions from code review

Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>

Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
When the code sample `InsertNewlinesEveryTenTextElements` is run, the first newline is 11 characters long when it is meant to be 10. This commit fixes that by making the `textElementCount` start at 1.
* Update linux-fedora.md

* Update linux-fedora.md
Facts cannot be stated in an imperative form. Otherwise, I would call it a "tip".
* Add with-expressions to anonymous types

Fixes dotnet#26770

With-expressions can be used with anonymous types.

* code review
Bumps [Humanizer](https://github.com/Humanizr/Humanizer) from 2.11.10 to 2.13.14.
- [Release notes](https://github.com/Humanizr/Humanizer/releases)
- [Changelog](https://github.com/Humanizr/Humanizer/blob/main/release_notes.md)
- [Commits](Humanizr/Humanizer@v2.11.10...v2.13.14)

---
updated-dependencies:
- dependency-name: Humanizer
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…otnet#27118)

* Update ExampleAsyncDisposable.cs

* Update ExampleConjunctiveDisposable.cs
* Add documentation for CA2255 (new in .NET 6)

* Address pr feedback
@ardalis
Copy link
Contributor Author

ardalis commented Nov 17, 2021

@IEvangelist should be a quick one.

@IEvangelist IEvangelist merged commit a942385 into dotnet:mordernize-web-apps-ebook-net6 Nov 17, 2021
@ardalis ardalis deleted the ardalis/modernizing-frontmatter branch February 2, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.