Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ca1841 #23887

Merged
merged 17 commits into from
Apr 23, 2021
Merged

Ca1841 #23887

merged 17 commits into from
Apr 23, 2021

Conversation

NewellClark
Copy link
Contributor

Summary

Documentation for analyzer CA1841.

@NewellClark NewellClark requested review from gewarren and a team as code owners April 22, 2021 19:49
@dotnet-bot dotnet-bot added this to the April 2021 milestone Apr 22, 2021
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the docs!

NewellClark and others added 10 commits April 23, 2021 00:33
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
…ings.md

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

```csharp
using System.Collections.Generic;
// Importing this namespace brings extension methods for IEnumerable`1 into scope.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Importing this namespace brings extension methods for IEnumerable`1 into scope.
// Importing this namespace brings extension methods for IEnumerable<T> into scope.

@gewarren gewarren merged commit fb720d4 into dotnet:main Apr 23, 2021

```vb
Imports System.Collection.Generic
' Importing this namespace brings extension methods for IEnumerable`1 into scope.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
' Importing this namespace brings extension methods for IEnumerable`1 into scope.
' Importing this namespace brings extension methods for IEnumerable(Of T) into scope.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops sorry Youssef.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, it happened that I commented at nearly the same time of you merging 😄
Will do the change in a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants