Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Storage integration rewrites. #2239

Merged
merged 41 commits into from
Dec 10, 2024
Merged

Azure Storage integration rewrites. #2239

merged 41 commits into from
Dec 10, 2024

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Dec 5, 2024 •
edited by github-actions bot
Loading

Summary

Azure Storage integration rewrites:

Internal previews

📄 File 🔗 Preview link
docs/fundamentals/app-host-overview.md .NET Aspire orchestration overview
docs/fundamentals/external-parameters.md External parameters
docs/fundamentals/integrations-overview.md .NET Aspire integrations overview
docs/storage/azure-storage-blobs-integration.md docs/storage/azure-storage-blobs-integration
docs/storage/azure-storage-queues-integration.md .NET Aspire Azure Queue Storage integration
docs/storage/azure-storage-tables-integration.md .NET Aspire Azure Data Tables integration
docs/toc.yml docs/toc

@dotnetrepoman dotnetrepoman bot added the storage Content related to storage. label Dec 5, 2024
@dotnet-policy-service dotnet-policy-service bot added the okr-quality Content-health KR: Concerns article defects/freshness or build warnings. label Dec 5, 2024
@IEvangelist IEvangelist marked this pull request as ready for review December 6, 2024 18:42
@davidfowl
Copy link
Member

We need to add some content about how to change the sku (and other properties) using ConfigureInfrastructure.

@IEvangelist
Copy link
Member Author

We need to add some content about how to change the sku (and other properties) using ConfigureInfrastructure.

Done! https://review.learn.microsoft.com/en-us/dotnet/aspire/storage/azure-storage-blobs-integration?branch=pr-en-us-2239&tabs=dotnet-cli#customize-provisioning-infrastructure

eerhardt
eerhardt reviewed Dec 9, 2024
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good. Way better than what we have today. Thanks

eerhardt
eerhardt approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @IEvangelist!

@IEvangelist @eerhardt
Apply suggestions from code review
4f0cd63 
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
@IEvangelist IEvangelist merged commit dfb6622 into dotnet:main Dec 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfowl davidfowl davidfowl left review comments

@eerhardt eerhardt eerhardt approved these changes

@DamianEdwards DamianEdwards Awaiting requested review from DamianEdwards

@maddymontaquila maddymontaquila Awaiting requested review from maddymontaquila

@tg-msft tg-msft Awaiting requested review from tg-msft

@BillWagner BillWagner Awaiting requested review from BillWagner

Assignees
No one assigned
Labels
okr-quality Content-health KR: Concerns article defects/freshness or build warnings. storage Content related to storage.
Projects
None yet
Milestone
No milestone
3 participants
@IEvangelist @davidfowl @eerhardt