Support a named global namespace #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jwittner, It will cover your contributions to all .NET Foundation-managed open source projects. |
|
@jwittner, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
36bd8e2 to
f59d56c
Compare
vwxyzh
approved these changes
Apr 6, 2017
superyyrrzz
reviewed
Apr 6, 2017
| { | ||
| Logger.LogWarning($"DocFX currently only supports generating metadata with namespace defined. The following types in assembly \"{symbol.MetadataName}\" will have no metadata generated: {string.Join(", ", typeMembers.Select(m => m.MetadataName))}. "); | ||
| namespaces = Enumerable.Repeat( symbol.GlobalNamespace, 1); |
There was a problem hiding this comment.
[](start = 47, length = 1)
minor: remove
|
|
f59d56c to
2cbf75a
Compare
qinezh
approved these changes
Apr 7, 2017
superyyrrzz
pushed a commit
that referenced
this pull request
Apr 7, 2017
* Avoid null deref by failing match with against null * Support global namespaces if a name is supplied
|
Thanks a ton for getting this in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows specifying an id for the global namespace and includes the global namespace in metadata generation if one is provided.
Resolves #1519