fix: Use provided references for search of dependencies in AssemblyCompilations #10491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation + small code duplication cleanup
yufeih
approved these changes
Jan 27, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10491 +/- ##
==========================================
+ Coverage 74.31% 79.33% +5.01%
==========================================
Files 536 547 +11
Lines 23189 23634 +445
Branches 4056 4066 +10
==========================================
+ Hits 17234 18751 +1517
+ Misses 4853 3711 -1142
- Partials 1102 1172 +70 ☔ View full report in Codecov by Sentry. |
filzrev
pushed a commit
to filzrev/docfx
that referenced
this pull request
Feb 18, 2025
…mpilations (dotnet#10491) * Use provided references for search for dependencies in AssemblyCompilation + small code duplication cleanup * Added code to warning * Fixes whitespace --------- Co-authored-by: Yufei Huang <yufeih@live.com>
filzrev
pushed a commit
to filzrev/docfx
that referenced
this pull request
Feb 18, 2025
…mpilations (dotnet#10491) * Use provided references for search for dependencies in AssemblyCompilation + small code duplication cleanup * Added code to warning * Fixes whitespace --------- Co-authored-by: Yufei Huang <yufeih@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use provided references for search of dependencies in AssemblyCompilations.
This should resolve my issue in #10423.
Since I did not get any feedback on how best resolve the issue I thought maybe this would get some attention. What this approach does is basicly use the provided Metadatareferences and use their filepaths (if present) to help resolve dependencies via filenames for those that are not found by default.
I also included a small code duplication cleanup, I hope thats also ok.