Allow output to be inferred from a section after the example instead of stated explicitly #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jskeet. Once this PR has been merged, I'll update the user guide and grammar (in my pending PR) to reflect this new option. |
BillWagner
approved these changes
Nov 1, 2022
There was a problem hiding this comment.
This is nice @jskeet
I had one comment that may affect its resilience over time. But it's ready to 
…of stated explicitly This allows us to test that the claimed output in the standard is *really* the output. In various cases, this wasn't actually the case... We still need ExpectedOutput at the moment for cases where the standard doesn't have the expected output in a triple-backtick-fenced block, but we could potentially aim to improve that over time.
99268d6 to
64c784b
Compare
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to test that the claimed output in the standard is really the output. In various cases, this wasn't actually the case...
We still need ExpectedOutput at the moment for cases where the standard doesn't have the expected output in a triple-backtick-fenced block, but we could potentially aim to improve that over time.
@RexJaeschke: I've added you to the review list just to make you aware of the functionality :)