Use LangVersion=8 where feasible in testing #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
trying a close and reopen. #1218 has already been merged, and that removes the attributes added in 9. Since there aren't any conflicts, that may be enough. |
BillWagner
approved these changes
Nov 22, 2024
|
I'll rebase and repush. |
This should allow us to avoid accidentally using C# 9+ features, at least in most cases. The standalone-console and standalone-console-without-using templates are unchanged, as many examples using them expect to use top-level statements. (Once we've got as far as C# 10, we should be able to use LangVersion for all projects.)
BillWagner
approved these changes
Nov 22, 2024
Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
|
Merged the suggestion - let's see whether we get to green... |
jskeet
commented
Nov 22, 2024
|
Fixed a typo, so let's wait another time... |
|
It's green :) Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that now both MaybeNull1Attribute and MaybeNull2Attribute fail to build - I believe this is correct, and should be reflected in spec changes which you may be doing already. Happy to wait until you're done, then rebase this.