Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix examples where feasible #1063

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Fix examples where feasible #1063

merged 1 commit into from
Mar 27, 2024

Conversation

jskeet
Copy link
Contributor

@jskeet jskeet commented Mar 27, 2024

Towards #646

@jskeet jskeet added the meeting: discuss This issue should be discussed at the next TC49-TG2 meeting label Mar 27, 2024
BillWagner
BillWagner approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @jskeet

Let's :shipit:

@jskeet jskeet merged commit cbf3a0d into dotnet:draft-v8 Mar 27, 2024
8 checks passed
@jskeet jskeet deleted the fix-examples branch March 27, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@RexJaeschke RexJaeschke Awaiting requested review from RexJaeschke

Assignees
No one assigned
Labels
meeting: discuss This issue should be discussed at the next TC49-TG2 meeting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jskeet @BillWagner