-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address async issues #1027
Merged
Merged
Address async issues #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#857 For an async method, say "produces a result value" vs. "return a value" when describing the rules for the returned "task type".
Fixes dotnet#878 I made this a note, rather than normative language. I read the existing text to allow the example in the issue (as does the roslyn implementation).
Fixes dotnet#775 Add a bullet to the list specifying that an `OperationCanceledException` puts the returned task in the cancelled state. This meant adding `OperationCanceledException` to the types in Annex C. I chose this fix because all known task builders conform to this behavior. It seems reasonable to standardize it.
Clarify the required accessibility of any task builder type and its required members. Note that we will need to update this text once dotnet/roslyn#71283 is fixed and merged.
The normative language on exactly matching accessibility is all that's strictly needed. But, I added a note about the implications for nested types and internal types.
515abf8
to
8ba95b1
Compare
jskeet
reviewed
Dec 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly fine (and thanks!), a few comments/questions.
BillWagner
commented
Feb 7, 2024
BillWagner
commented
Feb 7, 2024
BillWagner
commented
Feb 7, 2024
jskeet
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM again, after discussion.
BillWagner
commented
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each fix is in a single commit. In order:
Fixes #857: produces a result vs. returns a value.
Fixes #878
Fixes #775
Fixes #879
The fifth commit adds a note clarifying the meaning of the accessibility requirements for the task builder type and its corresponding task type.