Collection expressions: require Add method callable with a single argument for class and struct types that do not use [CollectionBuilder] #8022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ument for class and struct types that do not use [CollectionBuilder]
jnm2
approved these changes
Mar 26, 2024
AlekseyTs
reviewed
Mar 28, 2024
proposals/params-collections.md
Outdated
| in which case the *element type* is the *iteration type* | ||
| - The *type* has a constructor that can be invoked with no arguments, and the constructor is at least as accessible as the declaring member. | ||
| - The *type* has an instance (not an extension) method `Add` where: | ||
| - The method can be invoked with a single argument and the corresponding parameter is either by value or `in`. |
There was a problem hiding this comment.
Probably the bullet point should say the following instead:
- The method can be invoked with a single value (vs. ref/out/in) argument.
AlekseyTs
reviewed
Mar 28, 2024
proposals/params-collections.md
Outdated
| - The method can be invoked with a single argument and the corresponding parameter is either by value or `in`. | ||
| - If the method is generic, the type arguments can be inferred from the argument. | ||
| - The method is at least as accessible as the declaring member. | ||
| - In which case the *element type* is the [*iteration type*](https://github.com/dotnet/csharpstandard/blob/draft-v9/standard/statements.md#1395-the-foreach-statement) of the *type*. |
There was a problem hiding this comment.
- In which case the element type is the iteration type of the type.
This probably shouldn't be a bullet point. This is not one of the conditions #Closed
AlekseyTs
reviewed
Mar 28, 2024
| in which case the *element type* is the *iteration type* of the *type*. | ||
| * The *type* has an *[applicable](https://github.com/dotnet/csharpstandard/blob/standard-v6/standard/expressions.md#11642-applicable-function-member)* constructor that can be invoked with no arguments, and the constructor is accessible at the location of the collection expression. | ||
| * If the collection expression has any elements, the *type* has an instance or extension method `Add` where: | ||
| * The method can be invoked with a single argument and the corresponding parameter is either by value or `in`. |
AlekseyTs
reviewed
Mar 28, 2024
| * The method can be invoked with a single argument and the corresponding parameter is either by value or `in`. | ||
| * If the method is generic, the type arguments can be inferred from the collection and argument. | ||
| * The method is accessible at the location of the collection expression. | ||
| * In which case the *element type* is the [*iteration type*](https://github.com/dotnet/csharpstandard/blob/standard-v6/standard/statements.md#1295-the-foreach-statement) of the *type*. |
There was a problem hiding this comment.
- In which case the element type is the iteration type of the type.
Similar comment as for params spec #Closed
|
Done with review pass (commit 1) |
AlekseyTs
added a commit
to AlekseyTs/roslyn
that referenced
this pull request
Mar 28, 2024
AlekseyTs
added a commit
to AlekseyTs/roslyn
that referenced
this pull request
Mar 28, 2024
AlekseyTs
added a commit
to dotnet/roslyn
that referenced
this pull request
Mar 29, 2024
The main observable change - the original (unconverted) params arguments are used in the process of populating target collection. Spec changes: dotnet/csharplang#8022 Fixes #72098
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, collection expression conversion required an
Addmethod callable with a single argument of the iteration type if the collection expression has any elements. This is relaxed to anAddmethod callable with a single argument, without a requirement on the argument type.