Add speclet for file-local types #6233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RikkiGibson
commented
Jun 24, 2022
jcouv
reviewed
Jun 24, 2022
jcouv
reviewed
Jun 24, 2022
jcouv
reviewed
Jun 24, 2022
svick
reviewed
Jun 24, 2022
cston
reviewed
Jun 24, 2022
cston
reviewed
Jun 24, 2022
jcouv
reviewed
Jun 24, 2022
|
It was suggested in email thread with LDT that we do nothing re: attributes. i.e. you can declare 'file class C : System.Attribute' and use it in '[C]', and we won't give a diagnostic or do anything else unusual. It wasn't clear if we had consensus about that. |
cston
reviewed
Jul 8, 2022
proposals/file-types.md
Outdated
| @@ -137,14 +137,22 @@ namespace NS1 | |||
| Therefore, we don't specify the feature in terms of which scope the type is contained in, but rather as additional "filtering rules" in member lookup. | |||
|
|
|||
| ### Attributes | |||
| In the initial iteration of the feature, a file type is not allowed to be used as an attribute. Such attributes are of limited utility for users who are unaware of the internal name generation strategy used in the implementation. | |||
| File classes are permitted to be attribute types, and can be used as attributes within both file types and non-file types, just as if the attribute type were a non-file type. The metadata name of the file-local attribute type still goes through the same name generation strategy as other file-local types. This means detecting the presence of a file-type by a hard-coded string name is likely to be impractical, because it requires depending on the internal name generation strategy of the compiler, which may change over time. However, detecting via `typeof(MyFileLocalAttribute)` works. | |||
There was a problem hiding this comment.
There are several different names used: "file type", "file-local ... type", and "file-type". Consider choosing one or perhaps two names to use.
There was a problem hiding this comment.
Yeah, I'm going to make a pass to change everything to "file-local" types, here and in the implementation.
cston
approved these changes
Jul 8, 2022
cston
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to dotnet/roslyn#60819