Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax highlighting for records and init accessors #211

Merged
merged 2 commits into from
Jul 2, 2021
Merged

Add syntax highlighting for records and init accessors #211

merged 2 commits into from
Jul 2, 2021

Conversation

cschierig
Copy link
Contributor

This pull request adds syntax highlighting for records and init accessors.
It currently doesn't include positional record declarations as I haven't figured them out yet regex-wise.

This partly addresses #202 (Records highlighting is not supported).

@dnfadmin
Copy link

dnfadmin commented Jun 28, 2021

CLA assistant check
All CLA requirements met.

@kasperk81
Copy link

looks like you didn't build the project (with npm i which also runs gulp), otherwise you will have four files change in this pr.

@JoeRobich
Copy link
Member

@CozyPenguin Thanks for the contribution. I am going to add some tests and we will get this merged.

@JoeRobich JoeRobich merged commit 1c8879f into dotnet:main Jul 2, 2021
@kasperk81
Copy link

@JoeRobich, please also check-in the updated package-lock.json so there is no diff in clean repo after the build:

git clone https://github.com/dotnet/csharp-tmLanguage
cd csharp-tmLanguage
npm install # which also run gulp and builds it
git status

with current master on ubuntu with npm v7.5.2 and node v12.21.0, it gives:

	modified:   package-lock.json
	modified:   package.json

@JoeRobich
Copy link
Member

@kasperk81 Can you check again?

@kasperk81
Copy link

👍 retest the latest with npm v7.17 and above (latest is 7.19) no diffs after the build of fresh clone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants