Add test for dotnet/coreclr#18521 fix #32538
Conversation
|
This is passing ci even though that coreclr PR isn't merged. Is that expected? |
|
That is not expected. I must have messed up porting over the test from CoreCLR. I'll figure it out on Monday. |
598a62a to
143c138
Compare
|
As soon as CoreCLR commit 737d0ea is propagated to CoreFX this will be ready for review. |
|
Note that this is a breaking change: It is changing non-throwing behavior into a throwing one. I do not think we should be making breaking changes like this. |
|
@jkotas @luqunl @AaronRobinsonMSFT do you plan to revert the change in CoreCLR in that case? |
|
We have another change in flight that modifies where the exception is thrown. I'll update the tests in this PR once we decide whether or not to merge that PR. (Some of the tests in this PR should be merged anyway since they weren't breaking changes) |
|
Can you link the CoreCLR change in flight please? |
c9be05c to
5945e7b
Compare
|
We've decided to take a different direction on dotnet/coreclr#20375 so I've removed that test from this PR. When CI is green this PR is ready to merge. |
* Add test for dotnet/coreclrdotnet/corefx#18521 * Update StructureToPtrTests.cs * Add additional test case. * Disable tests on .NET Framework. * Add opaque struct in non-blittable struct test. Commit migrated from dotnet/corefx@ab753be
Adds a unit test for the fix in dotnet/coreclr#20194 based on the original repro.
Adds a unit test for dotnet/coreclr#20263