This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Disable automatic package restore in VS #10190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is breaking the VS build unless you disable it globally, which would interfere with work on other projects that depend on it working.
| @@ -10,4 +10,9 @@ | |||
| <config> | |||
| <add key="repositoryPath" value="..\packages" /> | |||
| </config> | |||
| <packageRestore> | |||
| <!-- Automated package restore in VS does not work at this time with | |||
| this project and it causes build failures in VS. Disable it. --> | |||
There was a problem hiding this comment.
Just so I understand, this is essentially unchecking the Automatically check for missing packages during build in Visual Studio option in VS, but only for things in corefx?
|
Looks good to me; I've long since disabled that setting globally since I find it kind of distracting/slow. And you are correct, restoring packages outside of VS is required unless something has changed. At various points in time, the built-in package manager couldn't actually successfully restore any of our projects. It probably still can't. |
macrogreg
pushed a commit
to open-telemetry/opentelemetry-dotnet-instrumentation
that referenced
this pull request
Sep 24, 2020
…-restore Disable automatic package restore in VS Commit migrated from dotnet/corefx@dc9c565
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is breaking the VS build unless you disable it globally, which would interfere with work on other projects that depend on it working.
I assume that running sync.cmd to restore packages is already a requirement before opening projects in VS, so this shouldn't break anything, but makes the VS experience work without damaging your global VS settings.