This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Move Buffer constants to platform specific files #23352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build breaks... |
jkotas
reviewed
Mar 21, 2019
| // Managed code is currently faster than glibc unoptimized memmove | ||
| // TODO-ARM64-UNIX-OPT revisit when glibc optimized memmove is in Linux distros | ||
| // https://github.com/dotnet/coreclr/issues/13844 | ||
| const nuint MemmoveNativeThreshold = ulong.MaxValue; |
There was a problem hiding this comment.
Nit: There should have explicitly specified visibility now that they are fields to follow the coding conventions.
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corefx
that referenced
this pull request
Mar 21, 2019
* Move Buffer constants to platform specific files * Add explicit access modifier Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corert
that referenced
this pull request
Mar 21, 2019
* Move Buffer constants to platform specific files * Add explicit access modifier Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/mono
that referenced
this pull request
Mar 21, 2019
* Move Buffer constants to platform specific files * Add explicit access modifier Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
stephentoub
pushed a commit
to dotnet/corefx
that referenced
this pull request
Mar 21, 2019
* Move Buffer constants to platform specific files * Add explicit access modifier Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Mar 21, 2019
* Move Buffer constants to platform specific files * Add explicit access modifier Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
marek-safar
added a commit
to mono/mono
that referenced
this pull request
Mar 22, 2019
* Move Buffer constants to platform specific files * Add explicit access modifier Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Move Buffer constants to platform specific files * Add explicit access modifier Commit migrated from dotnet/coreclr@ad30997
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.