This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fallback to old behavior when marshaling a non-blittable fixed buffer #20575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… buffers to/from native instead of on all marshalling operations.
…fer of a non-blittable type.
This was referenced Oct 24, 2018
jkotas
reviewed
Oct 24, 2018
src/vm/fieldmarshaler.cpp
Outdated
| #ifdef _DEBUG | ||
| INITFIELDMARSHALER(NFT_NESTEDVALUECLASS, FieldMarshaler_NestedValueClass, (thNestedType.GetMethodTable(), IsFixedBuffer(pfwalk->m_MD, pInternalImport))); | ||
| #else | ||
|
|
jkotas
approved these changes
Oct 24, 2018
|
@dotnet-bot test Ubuntu arm Cross Checked Innerloop Build and Test |
A-And
pushed a commit
to A-And/coreclr
that referenced
this pull request
Nov 20, 2018
…dotnet#20575) * Throw an exception only when attempting to marshal nonblittable fixed buffers to/from native instead of on all marshalling operations. * Assert in debug and checked builds when trying to marshal a fixed buffer of a non-blittable type.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…dotnet/coreclr#20575) * Throw an exception only when attempting to marshal nonblittable fixed buffers to/from native instead of on all marshalling operations. * Assert in debug and checked builds when trying to marshal a fixed buffer of a non-blittable type. Commit migrated from dotnet/coreclr@f7863cf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some offline discussions, we've decided to revert back to the old behavior when marshaling a non-blittable fixed buffer since all alternatives will very likely break someone and we don't get much real benefit out of it.
Also, add an assert for debug and checked builds to we can make sure that we don't try to marshal non-blittable fixed buffers while developing runtime features.
Supercedes #20558, #20263, and #20375