This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Turn on source link support #14399
Merged
Turn on source link support #14399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes us uniform. Allows VSCode (which does not suport MSPdbs) use on Windows.
|
It turns out that over the past few weeks we picked up an udpated C# which supports SourceLink with MS-PDBs, so I have avoiding the risk of moving to portable PDBs and just turned on the SourceLink support. I view this as completely uncontroversial. I will merge this later today unless someone screams in the next hour or two. @dagood @mikem8361 @ericstj @jkotas @lt72 @Petermarcu @markwilkie @weshaggard @tmat @Eilon @karelz @danmosemsft |
weshaggard
approved these changes
Oct 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn on SourceLink support. Also prep to convert to Portable PDBs (but not turned on yet.