This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
Add results-directory switch to dotnet test #6151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
livarcocc
reviewed
Mar 25, 2017
| @@ -109,7 +109,7 @@ public void TestWillCreateTrxLoggerInTheSpecifiedResultsDirectoryBySwitch() | |||
| // Call test with trx logger enabled and results directory explicitly specified. | |||
| CommandResult result = new DotnetTestCommand() | |||
| .WithWorkingDirectory(testProjectDirectory) | |||
| .ExecuteWithCapturedOutput("--logger:trx -r \"" + trxLoggerDirectory + "\""); | |||
| .ExecuteWithCapturedOutput("--logger trx -r \"" + trxLoggerDirectory + "\""); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
livarcocc
reviewed
Mar 27, 2017
| @@ -60,5 +60,10 @@ internal class LocalizableStrings | |||
|
|
|||
| public const string RunSettingsArgsHelpText = @"Any extra command-line runsettings arguments that should be passed to vstest. See 'dotnet vstest --help' for available options. | |||
| Example: -- RunConfiguration.ResultsDirectory=""C:\users\user\desktop\Results Directory"" MSTest.DeploymentEnabled=false"; | |||
|
|
|||
| public const string CmdResultsDirectoryDescription = @"The test results directory will be created in the specified path if it does not exist. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@dotnet-bot Test Ubuntu x64 Release Build |
|
@dotnet-bot Test Ubuntu x64 Release Build |
|
@dotnet-bot Test RHEL7.2 x64 Release Build |
|
@livarcocc Can you please review again? |
livarcocc
approved these changes
Apr 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@livarcocc @codito @piotrpMSFT